Redo statvar examples#717
Open
kmoscoe wants to merge 17 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the custom data documentation (custom_dc/custom_data.md) to revise the example statistical variables representing UN WHO cigarette smoking prevalence. The review feedback correctly identifies that Female and Male are not valid Class types in Data Commons and therefore cannot be used as populationType. The reviewer suggests reverting populationType to Person and using gender as a constraint property instead. Additionally, the feedback addresses a property name mismatch, a spelling typo ("prevelance" vs "prevalence"), and provides corresponding updates to the explanatory text.
* Add description of orderedFacets fields * Fix date types * Remove nav entry for V1 Python API * Revert "Remove nav entry for V1 Python API" This reverts commit 57bbf7f. * Undelete file and make it a redirect * Fix URL * Change redirect to redirect from and delete file.
This reverts commit 2c53d1c.
carojahn
requested changes
Jul 9, 2026
This reverts commit 2c53d1c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite stat var section to use a correct measuredProperty and statType, and add other fields, like measurementDenominator. Update CSV examples. Also rename to conform to convention guidelines.
Ignore the changes to llms-full.txt; I'm not sure why the tool is not updating it properly.