Add databricks-impulse into SDK and Spark Connect channel user-agents - #94
Merged
Merged
Conversation
…g Spark Connect sessions - Register `databricks-impulse` in the Databricks SDK process-global user-agent when the package is imported, guarded so import never fails. - Add `tag_spark_connect_user_agent()` to prepend the product/version tag to external Spark Connect sessions via their private channel-builder params. - Wire the Spark Connect tagging into `telemetry_logger` so methods that receive a `spark` argument attribute their compute automatically. - Add unit tests for global registration, idempotent Spark Connect tagging, classic-session no-op behavior, and decorator integration.
- Register SDK user-agent extra before product and log debug info when registration fails. - Match Spark Connect user-agent tags by product prefix so version substrings (e.g. 0.6.1 vs 0.6.10) cannot false-match. - Guard telemetry decorator signature binding so binding errors never break the wrapped business call. - Make import registration test deterministic by reloading the package in-body.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=======================================
Coverage 89.37% 89.38%
=======================================
Files 62 62
Lines 5544 5565 +21
Branches 680 682 +2
=======================================
+ Hits 4955 4974 +19
- Misses 466 468 +2
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tags Impulse's product identity onto both the SDK user-agent and the Spark Connect gRPC channel
Test Plan
Checklist