Read experimental_files_ext_enable_storage_proxy config from env var#1365
Open
yuanjieding-db wants to merge 1 commit intodatabricks:mainfrom
Open
Read experimental_files_ext_enable_storage_proxy config from env var#1365yuanjieding-db wants to merge 1 commit intodatabricks:mainfrom
yuanjieding-db wants to merge 1 commit intodatabricks:mainfrom
Conversation
yuanjieding-db
force-pushed
the
yuanjie/read-env-var-files-api-dp
branch
from
d0796d4 to
d49a9f0
Compare
yuanjieding-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read
experimental_files_ext_enable_storage_proxyfromDATABRICKS_EXPERIMENTAL_FILES_EXT_ENABLE_STORAGE_PROXYso the storage-proxy flag can be set via env (not only in code).Why
Matches other
Configenv-backed flags and simplifies use in jobs/notebooks.What changed
databricks/sdk/config.py:experimental_files_ext_enable_storage_proxyis nowConfigAttribute(env="DATABRICKS_EXPERIMENTAL_FILES_EXT_ENABLE_STORAGE_PROXY").Testing
Manual check: set the env var, build
Config()/WorkspaceClient(), confirm the flag is on. Existing tests that set the attribute in code still apply.