Fix cache warmer: add Windows runner, timestamp-based cache keys#1395
Merged
Fix cache warmer: add Windows runner, timestamp-based cache keys#1395
Conversation
1. Add Windows runner back to warmer matrix. GitHub Actions cache is
OS-scoped — Linux caches can't be restored on Windows.
2. Run exact same Maven commands as PR CI workflows to ensure all
plugins are cached.
3. Use timestamp in cache key (maven-deps-{timestamp}-{hash}) so each
warmer run creates a new entry without needing manual deletion.
GitHub caches are immutable. The restore step uses prefix
'maven-deps-' to match the latest entry. Old entries auto-expire
after 7 days.
Signed-off-by: Gopal Lal <gopal.lal@databricks.com>
Co-authored-by: Isaac
Signed-off-by: Gopal Lal <gopal.lal@databricks.com>
1. Add Windows runner to warmer matrix (OS-scoped cache). 2. Timestamp-based cache keys (no manual deletion needed). 3. Run exact CI commands to cache all plugins. 4. Enable long paths on Windows before checkout (repo has files exceeding 260-char Windows path limit). Signed-off-by: Gopal Lal <gopal.lal@databricks.com> Co-authored-by: Isaac Signed-off-by: Gopal Lal <gopal.lal@databricks.com>
gopalldb
force-pushed
the
fix/warm-cache-add-clean
branch
from
068c275 to
8fed9df
Compare
samikshya-db
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for the forked PR dependency cache:
Add Windows runner to warmer matrix. GitHub Actions cache is OS-scoped — a cache saved on Linux cannot be restored on Windows. The warmer must run on both OS.
Timestamp-based cache keys. GitHub caches are immutable (can't overwrite). Previously required manual deletion before re-running warmer. Now uses key format
maven-deps-{timestamp}-{hash}, so each run creates a new entry. The restore step uses prefixmaven-deps-to match the latest. Old entries auto-expire after 7 days.Also runs exact same Maven commands as PR CI workflows (8 steps) to ensure all plugins are cached.
Test plan
NO_CHANGELOG=true
This pull request was AI-assisted by Isaac.