Fix GEOMETRY/GEOGRAPHY DATA_TYPE mapping in Thrift getColumns()#1387
Open
sreekanth-db wants to merge 5 commits intomainfrom
Open
Fix GEOMETRY/GEOGRAPHY DATA_TYPE mapping in Thrift getColumns()#1387sreekanth-db wants to merge 5 commits intomainfrom
sreekanth-db wants to merge 5 commits intomainfrom
Conversation
The Thrift path in getThriftRows() was missing the geospatial type check for the DATA_TYPE column, causing GEOMETRY/GEOGRAPHY columns to return DATA_TYPE=0 (NULL) instead of the correct value. The SEA path already handled this correctly. Changes: - Add missing isGeospatialType() check in getThriftRows() DATA_TYPE handler, matching the existing SEA getRows() logic - Add GEOMETRY/GEOGRAPHY to getCode() mapping as Types.OTHER (1111), consistent with VARIANT handling - Add unit tests for both geospatial enabled and disabled scenarios Co-authored-by: Isaac Signed-off-by: Sreekanth Vadigi <[email protected]>
Co-authored-by: Isaac Signed-off-by: Sreekanth Vadigi <[email protected]>
vikrantpuppala
approved these changes
Apr 8, 2026
gopalldb
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getThriftRows()was missing theisGeospatialType()check for theDATA_TYPEcolumn ingetColumns(), causing GEOMETRY/GEOGRAPHY columns to returnDATA_TYPE=0(NULL) instead of the correct valuegetCode()mapping asTypes.OTHER(1111), consistent with VARIANT handlingDATA_TYPE=12(VARCHAR); when enabled:DATA_TYPE=1111(OTHER)Test plan
getCode()with GEOMETRY/GEOGRAPHYgetThriftRows()with geospatial enabled/disabledMetadataResultSetBuilderTestpasses (134 tests)