-
Notifications
You must be signed in to change notification settings - Fork 40
Add SPOG support for ?o= routing in httpPath #1316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msrathore-db
wants to merge
6
commits into
databricks:main
Choose a base branch
from
msrathore-db:spog-support-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e9bff6f
Add SPOG (Single Panel of Glass) support for ?o= routing
msrathore-db df5451e
Propagate x-databricks-org-id header to DBFS Volume API for SPOG routing
msrathore-db 6330ae5
Merge remote-tracking branch 'upstream/main' into spog-support-v2
msrathore-db 5686f9e
Fix warehouse regex for URL validation and add SPOG unit tests
msrathore-db 2f21d4d
Fix NPE in DBFSVolumeClient when connectionContext is null
msrathore-db 0f16824
Use URIBuilder for SPOG query param parsing
msrathore-db File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,8 +17,10 @@ public final class DatabricksJdbcConstants { | |
| "(?:/([^;]*))?" | ||
| + // Optional Schema (captured without /) | ||
| "(?:;(.*))?"); // Optional Property=Value pairs (captured without leading ;) | ||
| public static final Pattern HTTP_WAREHOUSE_PATH_PATTERN = Pattern.compile(".*/warehouses/(.+)"); | ||
| public static final Pattern HTTP_ENDPOINT_PATH_PATTERN = Pattern.compile(".*/endpoints/(.+)"); | ||
| public static final Pattern HTTP_WAREHOUSE_PATH_PATTERN = | ||
| Pattern.compile(".*/warehouses/([^?&]+).*"); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we also allow some other http paths, I guess /endpoints/ or something |
||
| public static final Pattern HTTP_ENDPOINT_PATH_PATTERN = | ||
| Pattern.compile(".*/endpoints/([^?&]+).*"); | ||
| public static final Pattern HTTP_CLI_PATTERN = Pattern.compile(".*cliservice(.+)"); | ||
| public static final Pattern HTTP_PATH_CLI_PATTERN = Pattern.compile("cliservice"); | ||
| public static final Pattern TEST_PATH_PATTERN = Pattern.compile("jdbc:databricks://test"); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use some Url parser utility for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use URI builder. Thanks