Commit a29d39b
authored
Fix batched insert regex to support backtick-quoted identifiers with special characters (#1403)
## Summary
- Fixed `INSERT_DETAILS_PATTERN` regex in `InsertStatementParser` to
support backtick-quoted identifiers containing special characters
(hyphens, spaces, escaped backticks, etc.) in table/schema/catalog names
- Added a `warn` log in
`PreparedStatementBatchExecutor.canUseBatchedInsert()` when parsing
fails and the driver falls back to individual execution
- Added unit tests for the new regex behavior
## Root Cause
The regex capture group for the table name matched characters
individually, so backtick-quoted identifiers with special characters
failed to match. The fix changes the group to match whole
backtick-quoted segments — allowing any character inside, including
escaped backtick pairs — or plain identifiers, separated by dots.
## Test plan
- [x] All `InsertStatementParserTest` tests pass
- [x] Verified against real Databricks warehouse with various table name
formats
- [x] Warn log confirmed to appear when fallback occurs
Fixes #1398
This pull request was AI-assisted by Isaac.
---------
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>1 parent 5742436 commit a29d39b
4 files changed
Lines changed: 72 additions & 1 deletion
File tree
- src
- main/java/com/databricks/jdbc
- api/impl
- common/util
- test/java/com/databricks/jdbc/common/util
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
75 | 79 | | |
76 | 80 | | |
77 | 81 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | | - | |
| 26 | + | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
Lines changed: 63 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
284 | 284 | | |
285 | 285 | | |
286 | 286 | | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
287 | 350 | | |
0 commit comments