Commit 5742436
authored
Fix getCrossReference case-insensitive parent matching (#1411)
## Summary
- `getCrossReference()` returned 0 rows when parent catalog/schema/table
args were passed in uppercase
- Root cause:
`CrossReferenceKeysDatabricksResultSetAdapter.includeRow()` used
`.equals()` for comparing user-provided parent args against
server-returned lowercase values
- Fixed by changing to `.equalsIgnoreCase()` — Databricks identifiers
are case-insensitive
## Test plan
- [x] Unit tests: 2 new tests for case-insensitive matching (12 total
pass)
- [x] End-to-end: verified with `getCrossReference(COMPARATOR_TESTS,
OSS_JDBC_TESTS, FK_PARENT, ...)` — SEA now returns 1 row matching Thrift
- [x] Tested on both Peco testing and Peco comparator workspaces
Signed-off-by: Sreekanth Vadigi <[email protected]>1 parent c594e81 commit 5742436
3 files changed
Lines changed: 43 additions & 3 deletions
File tree
- src
- main/java/com/databricks/jdbc/dbclient/impl/common
- test/java/com/databricks/jdbc/dbclient/impl/common
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
Lines changed: 39 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
128 | 167 | | |
129 | 168 | | |
130 | 169 | | |
| |||
0 commit comments