Clarify tag comparison rules in update-biobase skill - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last two automated biobase updates exposed two gaps in the skill file.
Tag comparison was ambiguous about rebuilds. Biocontainers tags look like
2.5.5--ha27dd3b_0. When a package is rebuilt, the trailing build number goes up and the hash changes. The old wording let an agent read the changed hash as "a different variant, not a newer build" and skip a real update. The rules now say plainly that a higher build number is a rebuild to take, regardless of the hash.A handful of tools also publish parallel
py310/py311/py313builds of the same version. Those are genuine ties, so there is now one line saying to take the highest one. Checked against all five such images currently in the manifest: this reproduces four of them exactly and would move macs2 from py310 to py311, which is the newer build of the same version.PR descriptions were unenforced. The old instruction asked for "a summary table plus a note", which one sentence technically satisfies. It is now a template with three required sections. The 'Checked, no update needed' section is the useful one: listing every image that was examined makes a shallow scan visible in the PR instead of invisible.
No manifest changes here, only the skill file.