Add checks for calls to exit#2642
Draft
natebosch wants to merge 4 commits into
Draft
Conversation
As suggested in #2640 An extension on `T Function()` allows expectations that the callback synchronously calls `exit` and returns a subject to check expectations on the exit code. An extension on `Future<T> Function()` allows expectations that the returned future does not complete before a call to `exit` is made. This catches both synchronous and asynchronous exits. The extension `on` type is more specific so it is possible to use the asynchronous code path in cases with statically asynchronous callbacks.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #2640
Closes #1657
An extension on
T Function()allows expectations that the callbacksynchronously calls
exitand returns a subject to check expectationson the exit code.
An extension on
Future<T> Function()allows expectations that thereturned future does not complete before a call to
exitis made. Thiscatches both synchronous and asynchronous exits. The extension
ontypeis more specific so it is possible to use the asynchronous code path in
cases with statically asynchronous callbacks.