[hooks_runner] Fix handling of executable paths and arguments containing spaces on Windows - #3466
Conversation
|
@dcharkes do you have any ideas on what would be the best way to share the |
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
Not really. It's an internal implementation detail that should not go in a public API. That's why it's copy-pasta. |
dcharkes
left a comment
dcharkes
left a comment
There was a problem hiding this comment.
We should also add a test that verifies that the hooks_runner works with spaces now.
|
This fails on the roll in Dart: https://dart-review.googlesource.com/c/sdk/+/523080 https://dart-ci.firebaseapp.com/cl/523080/1 new_test_failures__logs Could you take a look at the failures? And reproduce the failures locally with a Dart SDK build with the DEP file updated? (Otherwise, I'll have to revert this PR.) |
|
I'm guessing this is why runInShell was used. Let me try to create a regression test and test out a few solutions |
Roll in dart-lang/native#3466 before releasing hooks_runner to pub and rolling it to Flutter. Change-Id: I63af3959d3d1098351da8a2cc67819276076b546 Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/523080 Auto-Submit: Daco Harkes <dacoharkes@google.com> Reviewed-by: Michael Goderbauer <goderbauer@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
2 participants
Description
runProcessrunProcesshandling of executable paths that contain spacesRelated Issues
Fixes #2993
Relates to #3026
PR Checklist
dart tool/ci.dart --alllocally and resolved all issues identified. This ensures the PR is formatted, has no lint errors, and ran all code generators. This applies to the packages part of the toplevelpubspec.yamlworkspace.CHANGELOG.mdfor the relevant packages. (Not needed for small changes such as doc typos).