-
Notifications
You must be signed in to change notification settings - Fork 237
Specify error for pseudo-cyclic type parameter bounds #4743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eernstg
wants to merge
12
commits into
main
Choose a base branch
from
specify_433_aug26
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−13
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e3f94a5
Specify 433
eernstg ee658d2
Typo
eernstg 658fb4d
Improve rationale
eernstg 990d470
Typo
eernstg 1fd98c9
Correct examples
eernstg c8594aa
Remove the old rule about type variable cycles which is now obsolete
eernstg 4be6414
Correct commentary
eernstg db2c4da
WIP
eernstg b72728e
WIP
eernstg fbe3f4a
WIP
eernstg ef0f77c
WIP
eernstg 26bb318
WIP
eernstg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not.
You can always satisfy the bounds, but if you have
<X extends Y, Y extends FutureOf<X>>, you can assignYtoX, andawait (x as X)toY. You couldn't do that if you removed the bounds, and you can't just collapse them to one type variable, that wouldn't have the two different bounds.You could likely have reduced all of the variables to a single type variable with no bound, and added the
FutureOrand?on occurrences as needed. Maybe.But more relevantly
FutureOrand?are structural, soX extends FutureOf<X>has an infinitive expansion if one tries to be eager. That's bad.(A cycle with no union type shouldn't be a problem if it can be detected, it's just useless.)