Migrate to the prototype visitor API - #1955
Draft
liamappelbe wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
the
package:cupertino_http
dcharkes
reviewed
Jul 24, 2026
| import 'package:logging/logging.dart'; | ||
|
|
||
| class NativeCupertinoHttpVisitor extends Visitor { | ||
| static const includedInterfaces = { |
Contributor
There was a problem hiding this comment.
I'd probably inline this in the one method where it is used.
dcharkes
reviewed
Jul 24, 2026
| if (includedInterfaces.contains(node.originalName)) { | ||
| node.isExcluded = false; | ||
| for (final method in node.methods) { | ||
| if (node.originalName == 'NSURLResponse' && |
Contributor
There was a problem hiding this comment.
Maybe I'd try to make const maps with strings for the renames as well.
const methodRenames = {
'NSURLResponse' : {
'initWithURL:MIMEType:expectedContentLength:textEncodingName:':
'initWithUrlAndMIMEType',
},
'NSHTTPURLResponse': // ...
}and ditto for the param renames
That might be easier to read than the for loops.
Contributor
There was a problem hiding this comment.
Side note, we don't visit the methods and params and look up at the parents? That would avoid us having to have the for loops here. E.g. then we'd just reuse the visitParam and visitMethod that already traverse the whole ast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: dart-lang/native#3482
I'm not planning to merge this, just sharing what it would look like under the new API.