Support CLI arguments to the run_tests tool#164
Closed
natebosch wants to merge 1 commit into
Closed
Conversation
Add strong language to the `run_tests` tool description asserting it's use in favor of the CLI alternatives. Add support for forwarding arbitrary CLI arguments so the MCP version is equally powerful as the CLI versions. Check for a reporter argument specified by the client before assuming the failure only reporter should be used. This may allow a client to use the JSON reporter.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
jakemac53
reviewed
Jun 10, 2025
| return Tool( | ||
| name: 'run_tests', | ||
| description: | ||
| 'Run Dart tests with an agent centric UX. ' |
Contributor
There was a problem hiding this comment.
Suggested change
| 'Run Dart tests with an agent centric UX. ' | |
| 'Run Dart or Flutter tests with an agent centric UX. ' |
jakemac53
reviewed
Jun 10, 2025
| inputSchema: Schema.object( | ||
| properties: { | ||
| ParameterNames.roots: rootsSchema(supportsPaths: true), | ||
| 'args': Schema.list( |
Contributor
There was a problem hiding this comment.
nit: add args to ParameterNames
jakemac53
reviewed
Jun 10, 2025
jakemac53
left a comment
jakemac53
left a comment
Contributor
There was a problem hiding this comment.
Consider writing a test as well, for the reporter and args behavior
Member
Author
|
Superseded by #169 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add strong language to the
run_teststool description asserting it'suse in favor of the CLI alternatives. Add support for forwarding
arbitrary CLI arguments so the MCP version is equally powerful as the
CLI versions. Check for a reporter argument specified by the client
before assuming the failure only reporter should be used. This may
allow a client to use the JSON reporter.