Skip to content

feat: Added more conditions info #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dm94 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Added more conditions info #444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95ae6c4
Refactor QuestProxy for improved readability and consistency in updat…
dm94 Feb 8, 2026
7ce9e51
Merge branch 'master' into feat/more-condition-info
dm94 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions src/main/java/com/github/manolo8/darkbot/core/objects/facades/QuestProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,16 @@ public class QuestProxy extends Updatable implements QuestAPI {
private final QuestProxy.Quest questGiverSelected = new Quest();
private final QuestProxy.QuestListItem questGiverSelectedInfo = new QuestListItem();

private final FlashMap<Integer, QuestProxy.QuestListItem> questGiverItemsMap = FlashMap.of(Integer.class, QuestProxy.QuestListItem.class);
private final FlashMap<Integer, QuestProxy.QuestListItem> questGiverItemsMap =
FlashMap.of(Integer.class, QuestProxy.QuestListItem.class);

@Getter
private boolean questGiverOpen;

@Override
public void update() {
if (address == 0) return;
if (address == 0)
return;

this.questsUpdated = false;

Expand All @@ -38,7 +40,8 @@ public void update() {
this.currentQuest.update();

this.questGiverOpen = readBoolean(0x40);
if (!questGiverOpen) return;
if (!questGiverOpen)
return;

this.questGiverSelectedInfo.updateIfChanged(readAtom(0xA8));
this.questGiverSelectedInfo.update();
Expand All @@ -60,7 +63,8 @@ public void update() {

@Override
public @Nullable QuestAPI.QuestListItem getSelectedQuestInfo() {
return !this.questGiverOpen || questGiverSelectedInfo.address == 0 ? null : questGiverSelectedInfo;
return !this.questGiverOpen || questGiverSelectedInfo.address == 0 ? null
: questGiverSelectedInfo;
}

@Override
Expand Down Expand Up @@ -96,7 +100,8 @@ public void update(long address) {

@Override
public void update() {
if (address == 0) return;
if (address == 0)
return;

this.selected = readBoolean(0x34);
this.completed = readBoolean(0x38);
Expand All @@ -111,7 +116,8 @@ public static class Quest extends Updatable implements QuestAPI.Quest {
private boolean completed;
private String title;
private String description;
private final FlashList<QuestProxy.Requirement> requirements = FlashList.ofArray(Requirement::new);
private final FlashList<QuestProxy.Requirement> requirements =
FlashList.ofArray(Requirement::new);
private final FlashList<QuestProxy.Reward> rewards = FlashList.ofArray(Reward::new);

@Override
Expand All @@ -127,7 +133,8 @@ public void update(long address) {

@Override
public void update() {
if (address == 0) return;
if (address == 0)
return;

this.active = readBoolean(0x24);
this.completed = readBoolean(0x38, 0x38);
Expand Down Expand Up @@ -158,27 +165,33 @@ public void update() {
@Getter
@ToString
public static class Requirement extends Updatable implements QuestAPI.Requirement {
private final FlashList<QuestProxy.Requirement> requirements = FlashList.ofArray(Requirement::new);
private final FlashList<QuestProxy.Requirement> requirements =
FlashList.ofArray(Requirement::new);

private int id;
private String type;
private String description;
private double progress;
private double goal;
private boolean completed;
private boolean enabled;
private boolean subCondition;

@Override
public void update(long address) {
super.update(address);

this.requirements.update(readAtom(0x48));
this.id = readInt(0x20);
this.type = readString(0x58, 0x28);
this.description = readString(0x60);
this.subCondition = readBoolean(0x38);
}

@Override
public void update() {
if (address == 0) return;
if (address == 0)
return;

this.requirements.update();

Expand All @@ -188,4 +201,4 @@ public void update() {
this.goal = readDouble(0x80);
}
}
}
}
Loading