Skip to content

Return Assertion ID#25

Merged
darioackermann merged 3 commits into
darioackermann:masterfrom
peakon:andreas/patch-1
Mar 31, 2025
Merged

Return Assertion ID#25
darioackermann merged 3 commits into
darioackermann:masterfrom
peakon:andreas/patch-1

Conversation

@andreas

@andreas andreas commented Mar 31, 2025

Copy link
Copy Markdown

Adding logic to return assertion id during SAML binding.

Resolves Clever#274

(this is a port of Clever#273)

@darioackermann

Copy link
Copy Markdown
Owner

Thanks for opening the PR!

Could you

  • adjust the README.md accordingly (as in your original PR against clever/saml2-js)
  • return directly from get_assertion_id
get_assertion_id = (dom) ->
  assertion = dom.getElementsByTagNameNS(XMLNS.SAML, 'Assertion')
  throw new Error("Expected 1 Assertion; found #{assertion.length}") unless assertion.length is 1
  get_attribute_value assertion[0], 'ID'

@andreas

andreas commented Mar 31, 2025

Copy link
Copy Markdown
Author

Thanks for the feedback – I've updated accordingly now.

@darioackermann

Copy link
Copy Markdown
Owner

LGTM, thank you! 👍🏼
I'll release this soon!

@darioackermann darioackermann merged commit dd34983 into darioackermann:master Mar 31, 2025
@darioackermann

Copy link
Copy Markdown
Owner

Thanks for your contributions, v. 7.1.0 was just published on npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Return Assertion ID during SAML binding

3 participants