Conversation
…adata Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds OAuth credential support for the Zeebe bindings client and covers it with unit + certification tests, along with updating component metadata docs to expose the new configuration knobs.
Changes:
- Extend
ClientMetadatawith OAuth settings and wire a ZeebeCredentialsProviderinto client creation. - Add unit tests for OAuth credentials provider creation/validation behavior.
- Add certification tests for OAuth-enabled Zeebe command and jobworker scenarios; update component metadata YAML for new OAuth fields.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/certification/bindings/zeebe/jobworker/oauth_jobworker_test.go | New certification test validating jobworker behavior when OAuth metadata is configured. |
| tests/certification/bindings/zeebe/command/topology_oauth_test.go | New certification test validating command topology operation when OAuth metadata is configured. |
| bindings/zeebe/jobworker/metadata.yaml | Document new OAuth-related metadata options for the jobworker binding. |
| bindings/zeebe/command/metadata.yaml | Document new OAuth-related metadata options for the command binding (and fix missing type for CA cert). |
| bindings/zeebe/client.go | Add OAuth metadata fields and create/configure Zeebe OAuth credentials provider. |
| bindings/zeebe/client_test.go | Extend metadata parsing tests and add unit tests for OAuth provider creation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…criptions Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/certification/bindings/zeebe/command/topology_oauth_test.go
Outdated
Show resolved
Hide resolved
…adata inclusion Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/certification/bindings/zeebe/command/topology_oauth_test.go
Outdated
Show resolved
Hide resolved
tests/certification/bindings/zeebe/jobworker/oauth_jobworker_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Adds OAuth 2.0 client-credentials support for the Zeebe bindings (
zeebe.commandandzeebe.jobworker), covering end-to-end: client wiring, metadata validation, documentation, and certification tests.Changes
bindings/zeebe/client.goClientMetadatawith OAuth fields:clientId,clientSecret,authorizationServerUrl,tokenAudience,tokenScope,clientConfigPath.validateOAuthMetadata()that returns a component-ownedErrInvalidOAuthMetadataerror when only a subset of the required OAuth fields is set (requiresclientId,clientSecret,authorizationServerUrl, andtokenAudiencetogether).tokenScopeandclientConfigPathare optional OAuth fields, but they are valid only when used alongside the required OAuth field set above.newCredentialsProvider()calls validation before building the ZeebeOAuthCredentialsProvider, with optional YAML credentials cache path support.bindings/zeebe/client_test.gonewCredentialsProvider: no-op when OAuth is not configured, component-owned error (ErrorIs) when required fields are missing, success path with optional cache path.bindings/zeebe/command/metadata.yaml/bindings/zeebe/jobworker/metadata.yamlclientSecretmarkedsensitive: true.bindings/zeebe/jobworker/jobworker.goGetComponentMetadata()now reflects bothzeebe.ClientMetadataandjobWorkerMetadatavia a composedcomponentMetadatatype withmapstructure:",squash"tags, so OAuth/connection fields appear in runtime introspection alongside job-worker-specific fields.tests/certification/bindings/zeebe/command/topology_oauth_test.gotests/certification/bindings/zeebe/jobworker/oauth_jobworker_test.goIssue reference
Closes #4329
Checklist
clientSecretmarkedsensitive: truein component metadata