DAOS-18857 build: use env.get() for optional env var checks#18282
Open
knard38 wants to merge 1 commit into
Open
DAOS-18857 build: use env.get() for optional env var checks#18282knard38 wants to merge 1 commit into
knard38 wants to merge 1 commit into
Conversation
Replace the verbose 'KEY' in env and env['KEY'] pattern with the
idiomatic env.get('KEY') form for SANITIZERS and HEAP_PROFILER checks
throughout compiler_setup.py, as suggested in PR #18068 review.
env.get() returns None when the key is absent, which is falsy —
semantically equivalent to the original guards.
Signed-off-by: Cedric Koch-Hofer <[email protected]>
|
Ticket title is 'Support of Gperftools Heap Profiler' |
phender
approved these changes
May 19, 2026
daltonbohning
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the verbose
'KEY' in env and env['KEY']pattern with the idiomaticenv.get('KEY')form forSANITIZERSandHEAP_PROFILERchecks throughoutcompiler_setup.py, as suggested in PR #18068 review.env.get()returnsNonewhen the key is absent, which is falsy — semantically equivalent to the original guards.Steps for the author:
After all prior steps are complete: