Skip to content

DAOS-18834 cart: Add bulk, rpc and corpc metrics (#18037)#18271

Open
frostedcmos wants to merge 1 commit into
release/2.8from
frostedcmos/DAOS-18834-2.8
Open

DAOS-18834 cart: Add bulk, rpc and corpc metrics (#18037)#18271
frostedcmos wants to merge 1 commit into
release/2.8from
frostedcmos/DAOS-18834-2.8

Conversation

@frostedcmos
Copy link
Copy Markdown
Contributor

@frostedcmos frostedcmos commented May 18, 2026

  • Refactored how per-context metrics are stored: crt_internal_types.h now has a list of metrics and provides helper macros for manipulating them

  • Added metrics for: rpc send,receive,completed,reply,failures corpc initiate,complete,failures, bulk create,destroy,bind,failures

  • Old metrics converted to new format

  • Update telemetry_utils.py with new metrics

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@frostedcmos
DAOS-18834 cart: Add bulk, rpc and corpc metrics (#18037)
daf5b9a 
- Refactored how per-context metrics are stored:
  crt_internal_types.h now has a list of metrics and provides
  helper macros for manipulating them

- Added metrics for:
	rpc send,receive,completed,reply,failures
	corpc initiate,complete,failures,
	bulk create,destroy,bind,failures
- Old metrics converted to new format

- Update telemetry_utils.py with new metrics

Signed-off-by: Alexander A Oganezov <alexander.oganezov@hpe.com>
@frostedcmos frostedcmos requested review from a team as code owners May 18, 2026 14:52
@frostedcmos frostedcmos added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label May 18, 2026
daltonbohning
daltonbohning reviewed May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest changes LGTM

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented May 18, 2026

Test stage Build on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18271/1/execution/node/277/log

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented May 18, 2026

Test stage Build on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18271/1/execution/node/314/log

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented May 18, 2026

Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18271/1/execution/node/349/log

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Ticket title is 'cart: add rpc, corpc and bulk counters'
Status is 'Awaiting backport'
Labels: 'request_for_2.8'
https://daosio.atlassian.net/browse/DAOS-18834

@frostedcmos
Copy link
Copy Markdown
Contributor Author

frostedcmos commented May 18, 2026

Awaiting first merge/landing of @soumagne 's bulk addref patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

@tanabarr tanabarr tanabarr approved these changes

Assignees

No one assigned

Labels

unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frostedcmos @daosbuild3 @tanabarr @daltonbohning