Skip to content

DAOS-18889 object: client retry conditional ops for DER_TX_RESTART case #18270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nasf-Fan wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −0
Open

DAOS-18889 object: client retry conditional ops for DER_TX_RESTART case #18270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/object/srv_obj.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3228,6 +3228,18 @@ ds_obj_rw_handler(crt_rpc_t *rpc)
if (opc != DAOS_OBJ_RPC_UPDATE)
break;

/*
* For conditional update/insert, the -DER_TX_RESTART maybe caused by race among
* unsorted conditional insert operations on non-leader(s). Directly restart the
* transaction with newer epoch may cause more conflict. Instead, let's make the
* client to retry with random delay via replying -DER_INPROGRESS (to avoid fail
* old client if reply with -DER_TX_RESTART).
*/
if (orw->orw_api_flags & DAOS_COND_MASK) {
rc = -DER_INPROGRESS;
break;
}

/* Only standalone updates use this RPC. Retry with newer epoch. */
orw->orw_epoch = d_hlc_get();
exec_arg.flags |= ORF_RESEND;
Expand Down Expand Up @@ -4129,6 +4141,18 @@ ds_obj_punch_handler(crt_rpc_t *rpc)
rc = dtx_leader_end(dlh, ioc.ioc_coc, rc);
switch (rc) {
case -DER_TX_RESTART:
/*
* For conditional punch, the -DER_TX_RESTART maybe caused by race among
* unsorted conditional operations on non-leader(s). Directly restart the
* transaction with newer epoch may cause more conflict. Instead, let's
* make the client to retry with random delay via replying -DER_INPROGRESS
* (to avoid fail old client if reply -DER_TX_RESTART).
*/
if (opi->opi_api_flags & DAOS_COND_PUNCH) {
rc = -DER_INPROGRESS;
break;
}

/* Only standalone punches use this RPC. Retry with newer epoch. */
opi->opi_epoch = d_hlc_get();
exec_arg.flags |= ORF_RESEND;
Expand Down
Loading