DAOS-18943 build: Upgrade SPDK dependency to v26.01 by tanabarr · Pull Request #18172 · daos-stack/daos

tanabarr · 2026-05-04T21:52:18Z

This patch upgrades the SPDK dependency to version v26.01 which
includes significant changes and new features. The upgrade required
multiple compatibility fixes across the build system and codebase.

Update SPDK DAOS-dependency from v24.09 to v26.01
Bump daos-spdk package version to 3.0.0
Remove obsolete SPDK patches
Update external ISA-L patch for v26.01 compatibility
Upgrade ISA-L Crypto to v2.26 (aligned with SPDK v26.01)
Fix ISA-L Crypto include directory path in SPDK patch
Update ISA-L Crypto RPM changelog and package version to 2.26
Add 'uv' Python package manager to build requirements
(SPDK v26.01 now uses 'uv' for Python package installation)
Fix patchelf to skip non-ELF files (Python MCP scripts)
Replace deprecated spdk_pci_device_get_socket_id() with
spdk_pci_device_get_numa_id()

Test-tag: pr control full_regression

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
Appropriate Functional Test Stages were run.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

github-actions · 2026-05-04T21:52:35Z

Ticket title is 'Upgrade SPDK dependency from v24.09 to v26.01 for DAOS 2.8'
Status is 'In Review'
Labels: 'request_for_2.6.5,request_for_2.8'
https://daosio.atlassian.net/browse/DAOS-18943

tanabarr · 2026-05-12T10:11:51Z

blocked on DAOS-18019

+    quiet = 1
+EOF
+
+pip install --upgrade pip


+EOF
+
+pip install --upgrade pip
+pip install -r "$PREFIX"/lib/daos/TESTING/ftest/requirements-ftest.txt


+# from the read-only tree directly but for now that isn't working.
+# https://github.com/pypa/setuptools/issues/3237
+cp -a "$PREFIX"/lib/daos/python pydaos
+pip install ./pydaos


tanabarr · 2026-05-15T12:05:03Z

After applying #16919 , SPDK build failing on

[2026-05-14T15:45:57.212Z]   × Failed to build `spdk @
[2026-05-14T15:45:57.212Z]   │ file:///home/daos/pre/build/external/release/spdk/python`
[2026-05-14T15:45:57.212Z]   ├─▶ Failed to resolve requirements from `build-system.requires`
[2026-05-14T15:45:57.212Z]   ├─▶ No solution found when resolving: `hatchling`
[2026-05-14T15:45:57.212Z]   ├─▶ Request failed after 3 retries in 50.8s

[2026-05-14T15:45:57.212Z]   ├─▶ Failed to fetch: `[https://pypi.org/simple/hatchling/`](https://pypi.org/simple/hatchling/%60)
[2026-05-14T15:45:57.212Z]   ├─▶ error sending request for url (https://pypi.org/simple/hatchling/)
[2026-05-14T15:45:57.212Z]   ├─▶ client error (Connect)
[2026-05-14T15:45:57.212Z]   ╰─▶ operation timed out
[2026-05-14T15:45:57.212Z] make[1]: *** [Makefile:34: install] Error 1

any ideas @phender @jolivier23 ?
on edaos-15, where I am successfully building w/ SPDK v26.01 I can't find hatchling in pip list in the build virtualenv

(venv) [nabarrot@edaos-15 daos]$ pip list| grep hatch
(venv) [nabarrot@edaos-15 daos]$ uv pip list| grep hatchling
Using Python 3.9.21 environment at: venv
<no output>

I've added hatchling to requirements-build.txt in case this is a problem where the requirements need to be downloaded at a different stage for some reason. - didn't work

daosbuild3 · 2026-05-18T04:23:37Z

Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18172/15/testReport/

daosbuild3 · 2026-05-18T04:30:32Z

Test stage Unit Test with memcheck completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18172/15/testReport/

daosbuild3 · 2026-05-18T06:01:15Z

Test stage Unit Test bdev with memcheck completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18172/15/testReport/

tanabarr · 2026-05-18T08:57:53Z

@@ -192,12 +192,11 @@ EOF

 # Set up the uv (a part of SPDK installer)


shouldn't the comment also be indented?

tanabarr · 2026-05-18T08:58:34Z

thanks @grom72

- Update SPDK version from v24.09 to v26.01 - Remove obsolete patches - Update daos-spdk package version to 3.0.0 Features: full_regression Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

…, print SPDK version to INFO in engine log Test-tag: pr full_regression Priority: 2 Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

SPDK's Python package installer uses uv, which does not read /etc/pip.conf. Add /etc/uv/uv.toml in the repo-helper scripts for EL8, EL9 and Leap15 to redirect uv to the internal Artifactory PyPI proxy and enable native-tls so uv uses the system CA trust store (where the lab CA is already registered). Without this, uv falls back to pypi.org which is unreachable in lab environments, causing the SPDK build to fail with a connection timeout or an UnknownIssuer TLS error. ref: spdk/spdk@52d2355 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Test-tag: pr full_regression Priority: 2 Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

daltonbohning · 2026-05-18T16:57:15Z

+**Note:** Starting with SPDK v26.01, the 'uv' Python package manager is required to build SPDK's
+Python modules. This is automatically installed when you run the above `pip install -r requirements-build.txt`
+command. If you encounter "uv: command not found" errors during the build, ensure you have run this
+step or manually install uv with `pip install uv`.
+


Is this really necessary? If someone is following this guide from the start, shouldn't they have already run the install command above before getting to this comment?

I will remove this if I have to re-push or as a follow-up, thanks

daosbuild3 · 2026-05-19T01:08:33Z

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-18172/17/display/redirect

daosbuild3 · 2026-05-19T20:25:29Z

Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18172/18/testReport/

daosbuild3 · 2026-05-20T08:06:54Z

Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18172/19/testReport/

Test-tag: pr full_regression Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

Features: control pool Doc-only: false Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

daosbuild3 · 2026-05-20T19:29:56Z

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18172/22/execution/node/645/log

Features: control pool Priority: 2 Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

…de-v26.01 Priority: 2 Features: control pool Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

daosbuild3 · 2026-05-20T20:36:58Z

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18172/22/execution/node/624/log

tanabarr requested a review from jolivier23 May 4, 2026 22:10

tanabarr force-pushed the tanabarr/spdk-upgrade-v26.01 branch 2 times, most recently from 805102c to 221f10c Compare May 7, 2026 21:32

tanabarr self-assigned this May 12, 2026

tanabarr marked this pull request as ready for review May 12, 2026 10:10

tanabarr requested review from a team as code owners May 12, 2026 10:10

tanabarr requested a review from a team as a code owner May 12, 2026 12:42

tanabarr requested a review from a team as a code owner May 12, 2026 17:29

tanabarr requested review from a team as code owners May 14, 2026 15:34

github-advanced-security AI found potential problems May 14, 2026

View reviewed changes

tanabarr commented May 18, 2026

View reviewed changes

tanabarr added 6 commits May 18, 2026 16:41

DAOS-18943 build: Upgrade SPDK dependency to v26.01

a672a1a

- Update SPDK version from v24.09 to v26.01 - Remove obsolete patches - Update daos-spdk package version to 3.0.0 Features: full_regression Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

update isa-l-crypto version in line with SPDK v26.01

35bd3e6

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

fix isa-l_crypto include dir path

d216393

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

address API changes and add uv python package to build requirements

6a3d32c

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

only patch elf files, specifically not python MCP scripts

dcaa030

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

remove dpdk --no-telemetry opt now set by default in SPDK v26.1

832ca61

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

tanabarr and others added 6 commits May 18, 2026 16:41

update docs for uv dep and spdk/dpdk log level envs

74eb70c

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

update daos-spdk version to 26.01 from 3.0.0

b1d1ffb

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

add hatchling to build requirements to avoid SPDK build failure in CI…

a9fd3bb

…, print SPDK version to INFO in engine log Test-tag: pr full_regression Priority: 2 Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

Fix: remove redundant fi command

2a76665

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

fix unit test for dpdk_cli_opts_tests

e52b848

Test-tag: pr full_regression Priority: 2 Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

tanabarr force-pushed the tanabarr/spdk-upgrade-v26.01 branch from 09c6bb4 to e52b848 Compare May 18, 2026 16:02

daltonbohning reviewed May 18, 2026

View reviewed changes

tanabarr requested review from a team, NiuYawei and kjacque May 19, 2026 10:48

daltonbohning removed request for a team May 19, 2026 14:46

tanabarr added 2 commits May 20, 2026 10:22

add valgrind for new DPDK 25.11 issue

f388d84

Test-tag: pr full_regression Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

remove unnecessary text

bb0f7fb

Features: control pool Doc-only: false Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

tanabarr force-pushed the tanabarr/spdk-upgrade-v26.01 branch from 79c2b0b to bb0f7fb Compare May 20, 2026 10:06

tanabarr requested a review from daltonbohning May 20, 2026 10:07

NiuYawei previously approved these changes May 20, 2026

View reviewed changes

tanabarr added 2 commits May 20, 2026 21:32

fix deprecated enable_vmd -> vmd_enable SPDK rpc

4b2577a

Features: control pool Priority: 2 Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

Merge remote-tracking branch 'origin/master' into tanabarr/spdk-upgra…

a8a74ca

…de-v26.01 Priority: 2 Features: control pool Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

tanabarr dismissed NiuYawei’s stale review via a8a74ca May 20, 2026 20:35

tanabarr requested review from a team as code owners May 20, 2026 20:35

tanabarr requested a review from NiuYawei May 20, 2026 20:36

		@@ -192,12 +192,11 @@ EOF

		# Set up the uv (a part of SPDK installer)

Conversation

tanabarr commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps for the author:

After all prior steps are complete:

Uh oh!

github-actions Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tanabarr commented May 12, 2026

Uh oh!

tanabarr commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daosbuild3 commented May 18, 2026

Uh oh!

daosbuild3 commented May 18, 2026

Uh oh!

daosbuild3 commented May 18, 2026

Uh oh!

tanabarr May 18, 2026

Choose a reason for hiding this comment

Uh oh!

tanabarr commented May 18, 2026

Uh oh!

daltonbohning May 18, 2026

Choose a reason for hiding this comment

Uh oh!

tanabarr May 19, 2026

Choose a reason for hiding this comment

Uh oh!

daosbuild3 commented May 19, 2026

Uh oh!

daosbuild3 commented May 19, 2026

Uh oh!

daosbuild3 commented May 20, 2026

Uh oh!

daosbuild3 commented May 20, 2026

Uh oh!

daosbuild3 commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

tanabarr commented May 4, 2026 •

edited

Loading

github-actions Bot commented May 4, 2026 •

edited

Loading

tanabarr commented May 15, 2026 •

edited

Loading