Conversation
Remove user_id ownership check when saving fuel price history, allowing price records to be created for any station (not just user-owned ones). Remove user_id filter from dashboard cheapest fuel query so all price data is visible regardless of which user recorded it. Fixes #75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
When fuel stations were made system-wide in #57, two places still had user-scoped checks:
app/routes/fuel.py:104— Price history was only saved whenstation.user_id == current_user.id, so shared station users never had prices recordedapp/routes/main.py:113— Dashboard query filteredFuelPriceHistory.user_id == current_user.id, hiding prices recorded by other usersChanges
Fixes #75
Test plan