Conversation
Glassyiris
approved these changes
Sep 15, 2026
Author
|
Third commit adds what the dashboard comparison on #1 asked for: |
Zakkaus
force-pushed
the
ui-findings
branch
from
September 15, 2026 18:32
0ada659 to
8bd9871
Compare
Coherent connection and flow examples; open base objects so generators can extend them; sampled_at on traffic; src and connection_id filters; GroupSummary.config_revision; probe queue-full 503 with Retry-After; health identity carries measurement; decision-time names in selection paths; CORS, datapath and cursor rules stated once.
Example timestamps fall after instance start; the preflight rule is stated in api-config and common; health identity keeps warmth; wording.
chain, rule, ingress and domain source with provenance on Connection and FlowSummary; GET /runtime/outbounds; bounded GET /runtime/traffic/history; no-close and out-of-scope statements.
ErrorCode enum on HTTP error bodies (ApiError); errors embedded in resources keep adapter-defined codes; /events 409 names event_cursor_expired and carries an example.
Zakkaus
force-pushed
the
ui-findings
branch
from
September 15, 2026 18:39
8bd9871 to
f9a6a45
Compare
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1: the first four commits are #1 unchanged, only 668be4d is new here. It resolves every item in the review on #1 (comment 5679072758).
npm run check:contractpasses: 25 tests, 62 examples;source/openapi.yamlis regenerated by the bundle step only.Examples and schemas
/connectionsexample: totals match the listed entries.flow-23carriestcp-01HZX4K8W5's connection id, tuple and start; the unrelated interleaved example isflow-24/tcp-24. Test added.OperationCommon.resultandRouteStepData.input:additionalProperties: true, so generators keep the refined result and input shapes (checked with openapi-typescript: successful-operation results are typed again; flipping it back also fails redocly's example validation). Test added.stale_untilprose matches the schema (required, string or null).POST /probesgets its own queue-full 503 with a required positiveRetry-After; the sharedUnavailableis unchanged. Test rejects a missing or zero header.Additions a dashboard needs
TrafficSummary.sampled_at(required, nullable),rates.window_secondsdefined relative to it; runtime-status.md says there is no history and that connection sums are not usage.srconGET /connections(IP literal, applied beforelimit; totals andtruncatedrelative to it) andconnection_idonGET /flows(instance-scoped, no tuple guessing).GroupSummary.config_revision, the same opaque string as the detail.node.healthunique by (transport, purpose, measurement, ip_version); node-latency.md states the single-column rule.SelectionPathItem.member_name,SelectionCandidate.member_name/leaf_node_name: sanitized names captured at decision time, null when unavailable; ids stay authoritative.Prose
active/degradedmean forkind: userspace, and whatmockmay claim./nodesand/dns/cache(common.yaml description plus both docs).The example and
additionalPropertiesparts are independent of the rest; drop any hunk that goes further than wanted.