[Breaking] Remove Layout Mode and Size Storage#51
Open
ppth0608 wants to merge 7 commits into
Open
Conversation
Contributor
Author
|
@jaxtynSong 이 작업하신 내용이에요. PR만 대신 올렸어요! |
stleamist
reviewed
Jul 22, 2025
|
|
||
| final class CollectionViewMock: UICollectionView { | ||
|
|
||
| private var windowView = UIWindow() |
Contributor
There was a problem hiding this comment.
p3; 주입되지 않는 속성이라 private let으로 작성해도 될 것 같은데 어떨까요?
Suggested change
| private var windowView = UIWindow() | |
| private let _window = UIWindow() |
OhKanghoon
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the deprecated layout mode system and component size storage
functionality from
KarrotListKit. These features were no longer being used andadded unnecessary complexity to the codebase.
Changes
Componentprotocol andAnyComponentContentLayoutModeenum entirelysizeStoragefunctionalityComponentSizeStorageclassCollectionViewAdapterandCollectionViewLayoutAdaptableDefaultCompositionalLayoutSectionFactory,HorizontalLayout,VerticalGridLayout, andVerticalLayoutclassesCompositionalLayoutSectionFactoryby removing layout-specificlogic
Impact
This is a breaking change that removes previously deprecated APIs. Projects
using layoutMode, sizeStorage, or the removed layout classes will need to
migrate to alternative approaches.
Testing