Skip to content

Performance fix for removing nodes from data store - #2718

Draft
MetRonnie wants to merge 10 commits into
cylc:masterfrom
MetRonnie:data-store-perf
Draft

MetRonnie wants to merge 10 commits into
cylc:masterfrom
MetRonnie:data-store-perf

Conversation

@MetRonnie

Copy link
Copy Markdown
Member

Built on:

Massive speed up for removing workflows and their child cycles/families/tasks/jobs from the data store, by avoiding doing a bottom-up remove.

This is now O(n) instead of O(n2), as it avoids n unnecessary removeChild() calls, which is itself O(n)

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are not needed
  • Changelog entry included if this is a change that can affect users
  • Docs not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant