Repository navigation
aotf: replace "reload" with validateReinstall - #2347
Conversation
|
(drafting this feature until an 8.7.0 aligned milestone) |
04cd69e to
ac4bd73
Compare
|
(test will fail until introspection query is updated with the new mutation(s), will wait for upstream PR to be merged first) |
* The `reload` mutation isn't the most helpful command post `cylc install`. * Swap it out in the workflow command shortlist for the [newly added](cylc/cylc-uiserver#746) `validateReinstall` mutation which has wider scope.
6eb0da7 to
2c2aa17
Compare
|
I've rebased onto master and pushed the updated introspection query |
2c2aa17 to
301798e
Compare
|
@jfrost-mo - the first commit addresses the OP. The "introspection query" is a GraphQL query which retrieves the schema itself. We run this query in the UI on startup and use it to populate all the menus. We used to hardcode a dummy response in the UI test data so we could poke at the menus in UI tests. At some point we started bundling the real result, presumably so we could test a couple of interactions it has in the UI code itself (e.g, which commands are displayed in the shortlist). There's no process to auto-update the introspection query - it doesn't matter massively if they drift. Ronnie has done a one-off update which makes up the majority of the diff here - you don't need to review it! |
jfrost-mo
left a comment
There was a problem hiding this comment.
Looked over the files other than IntrospectionQuery.json, and it looks sensible.
However, the icons don't seem to be being set properly, and the bare "reload" option is perhaps unduly prominent if most people should be using this instead.
jfrost-mo
left a comment
There was a problem hiding this comment.
Have retested having actually run yarn run build this time, and it is working properly now. Happy to approve.
reloadmutation isn't the most helpful command postcylc install.validateReinstallmutation which has wider scope.Providing both "reload" and "validate reinstall" as refresh-like options is a bit unclear, so I opted to replace reload (which doesn't serve much function without reinstall) with validate-reinstall. Obvs the reload command is still there for those who need it, but no longer prominently advertised.
Will add a screen recording to the docs and a changes entry there once agreed on this one.
Needs:
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.