Skip to content

aotf: replace "reload" with validateReinstall - #2347

Merged
MetRonnie merged 3 commits into
cylc:masterfrom
oliver-sanders:validate-reinstall
Oct 7, 2026
Merged

MetRonnie merged 3 commits into
cylc:masterfrom
oliver-sanders:validate-reinstall

Conversation

@oliver-sanders

@oliver-sanders oliver-sanders commented Nov 3, 2025 •

Copy link
Copy Markdown
Member
  • The reload mutation isn't the most helpful command post cylc install.
  • Swap it out in the workflow command shortlist for the newly added validateReinstall mutation which has wider scope.

Providing both "reload" and "validate reinstall" as refresh-like options is a bit unclear, so I opted to replace reload (which doesn't serve much function without reinstall) with validate-reinstall. Obvs the reload command is still there for those who need it, but no longer prominently advertised.

Will add a screen recording to the docs and a changes entry there once agreed on this one.

Needs:

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users - meh - will add a global changelog though
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 2.11.0 milestone Nov 3, 2025
@oliver-sanders oliver-sanders self-assigned this Nov 3, 2025
Comment thread src/utils/aotf.js
@oliver-sanders
oliver-sanders marked this pull request as draft November 24, 2025 17:13
@oliver-sanders

Copy link
Copy Markdown
Member Author

(drafting this feature until an 8.7.0 aligned milestone)

@oliver-sanders oliver-sanders removed this from the 2.11.0 milestone Nov 27, 2025
@oliver-sanders
oliver-sanders marked this pull request as ready for review February 20, 2026 15:19
@oliver-sanders oliver-sanders added this to the 2.13.0 milestone Feb 20, 2026
@oliver-sanders

Copy link
Copy Markdown
Member Author

(test will fail until introspection query is updated with the new mutation(s), will wait for upstream PR to be merged first)

@oliver-sanders oliver-sanders modified the milestones: 2.13.0, 2.14.0 Feb 24, 2026
@oliver-sanders oliver-sanders modified the milestones: 2.14.0, 2.x May 6, 2026
@MetRonnie MetRonnie closed this Oct 5, 2026
@MetRonnie MetRonnie reopened this Oct 5, 2026
* The `reload` mutation isn't the most helpful command post
  `cylc install`.
* Swap it out in the workflow command shortlist for the
  [newly added](cylc/cylc-uiserver#746)
  `validateReinstall` mutation which has wider scope.
@MetRonnie
MetRonnie force-pushed the validate-reinstall branch 3 times, most recently from 6eb0da7 to 2c2aa17 Compare October 5, 2026 14:33
@MetRonnie

Copy link
Copy Markdown
Member

I've rebased onto master and pushed the updated introspection query

@MetRonnie MetRonnie modified the milestones: 2.x, 2.15.0 Oct 5, 2026
@MetRonnie MetRonnie self-assigned this Oct 5, 2026
@oliver-sanders

Copy link
Copy Markdown
Member Author

@jfrost-mo - the first commit addresses the OP.

The "introspection query" is a GraphQL query which retrieves the schema itself. We run this query in the UI on startup and use it to populate all the menus.

We used to hardcode a dummy response in the UI test data so we could poke at the menus in UI tests. At some point we started bundling the real result, presumably so we could test a couple of interactions it has in the UI code itself (e.g, which commands are displayed in the shortlist).

There's no process to auto-update the introspection query - it doesn't matter massively if they drift. Ronnie has done a one-off update which makes up the majority of the diff here - you don't need to review it!

@jfrost-mo jfrost-mo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over the files other than IntrospectionQuery.json, and it looks sensible.

However, the icons don't seem to be being set properly, and the bare "reload" option is perhaps unduly prominent if most people should be using this instead.

Comment thread src/utils/aotf.js
Comment thread src/utils/aotf.js

@jfrost-mo jfrost-mo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have retested having actually run yarn run build this time, and it is working properly now. Happy to approve.

@MetRonnie
MetRonnie merged commit 6f59cfa into cylc:master Oct 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants