Repository navigation
expiry: clarify late expiry events - #7505
Open
oliver-sanders wants to merge 1 commit into
Open
oliver-sanders wants to merge 1 commit into
oliver-sanders wants to merge 1 commit into
Conversation
* Addresses cylc/cylc-doc#974 * Add some text to the examples section explaining when expiry happens.
1 task done
hjoliver
reviewed
Oct 5, 2026
Comment on lines
+91
to
+94
|
|
||
| If you need something in your workflow to happen at a configured time, use | ||
| :term:`clock triggers <clock trigger>` rather than triggering off of the | ||
| ``:expired`` output. |
Member
There was a problem hiding this comment.
Suggested change
| If you need something in your workflow to happen at a configured time, use | |
| :term:`clock triggers <clock trigger>` rather than triggering off of the | |
| ``:expired`` output. |
I'd suggest not putting this here, unless you have evidence that users try to use expiry for this purpose? Triggering off of an expiry event seems an odd way to attempt anything other than respond to the expiry itself (i.e. "this task expired, it's not going to run, so do this instead").
Besides, clock triggers actually have a similar "lateness" problem to expiry - they aren't checked until the dependent task enters the active window, so clock triggers make things happen after, not at, a configured time.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with cylc/cylc-doc#974
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.