Repository navigation
changes: cylc vr in the gui - #978
Conversation
There was a problem hiding this comment.
Unrelated: Remove the executable permission from this png.
jfrost-mo
left a comment
jfrost-mo
left a comment
There was a problem hiding this comment.
New change addition looks sensible, but the spacing after the image should really be done via CSS. I'm happy if that change is broken out into a separate PR if preferable.
|
|
||
| | |
There was a problem hiding this comment.
| | |
While I see this is a common technique across this file, it not really correct to add an extra element for a purely presentational issue. Instead, these should be removed and the following should be added to custom.css.
/* Add some vertical margin to images to prevent crowding. */
.rst-content img.align-center {
margin-top: 24px;
margin-bottom: 24px;
}I've also thrown a pull request up on the upstream theme repository, though it doesn't look that active.
There was a problem hiding this comment.
Yes, this is a workaround for a problem which should be solved in the theme.
We can redact our in-content styling once it's redundant.
There was a problem hiding this comment.
I've put this up as cylc/cylc-sphinx-extensions#93, so we'll fix it separately to this PR. In which case happy for this to be merged.
2 participants
Changes entry for the recently merged UI PR.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.