Repository navigation
expiry: clarify late expiry #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oliver-sanders
wants to merge
1
commit into
cylc:master
Choose a base branch
from
oliver-sanders:699
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe say expiry can only be detected in active waiting tasks. Other (future tasks) can expire, but they won't until they become active.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(It could also be noted that the purpose of expiry to is cancel a task before it runs, so in light of that purpose it is OK if expiry is detected "late" relative to the configured clock time, so long as it is detected before the task runs ... but I think that's been said elsewhere already).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Cylc 7 we had
clock-triggerandclock-expireside-by-side, and both worked, kinda similarly. Due to SoS, the next instance of each task was spawned ahead of time, activating expiry detection.With Cylc 8, expiry in future cycles is more adversely delayed by current cycles due to delayed spawning and as a result, this was once reported as a Cylc 8 migration issue.
As a result, in the optional output proposal, we added point 9 to document that expiry events are not instantaneous - the issue got lost for a while, I picked it up last week: https://cylc.github.io/cylc-admin/proposal-optional-output-extension.html#proposal
Example Cylc 7 use cases might look like this:
With Cylc 8, the way to achieve this would likely be to use a clock-trigger to detect expiry, rather than a clock-expire: