Repository navigation
document 7209 - removal of graph orphans on reload/restart - #973
Open
oliver-sanders wants to merge 3 commits into
Open
oliver-sanders wants to merge 3 commits into
oliver-sanders wants to merge 3 commits into
Conversation
8 tasks done
oliver-sanders
commented
Oct 1, 2026
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
oliver-sanders
commented
Oct 1, 2026
Comment on lines
-150
to
-152
| If dependencies have changed, tasks that were already active will spawn | ||
| children according to their original outputs. Subsequent instances will have | ||
| the new settings. |
Member
Author
There was a problem hiding this comment.
I think this has been wrong for a while now.
MetRonnie
changed the title
hjoliver
requested changes
Oct 1, 2026
hjoliver
left a comment
hjoliver
left a comment
Member
There was a problem hiding this comment.
Good, just suggested some minor edits for grammar and conciseness.
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
MetRonnie
reviewed
Oct 2, 2026
Comment on lines
+36
to
+39
| Active instances of tasks removed from the | ||
| :term:`graph` by restart or reload will now be removed from the workflow | ||
| (i.e, ``cylc remove``). If they have active jobs, they will be | ||
| killed. |
Member
There was a problem hiding this comment.
I would be tempted to align more closely to my suggested changelog entry for the cylc-flow PR
Suggested change
| Active instances of tasks removed from the | |
| :term:`graph` by restart or reload will now be removed from the workflow | |
| (i.e, ``cylc remove``). If they have active jobs, they will be | |
| killed. | |
| When you delete tasks from the :term:`graph` and then reinstall and | |
| reload/restart the workflow, Cylc will now kill and remove any active instances | |
| of those tasks (as ``cylc remove`` would do). |
Member
There was a problem hiding this comment.
The current phrasing is partly my fault, but as it happens I was also considering whether "removed by reload or restart" is potentially confusing.
My variant of this tweak:
Suggested change
| Active instances of tasks removed from the | |
| :term:`graph` by restart or reload will now be removed from the workflow | |
| (i.e, ``cylc remove``). If they have active jobs, they will be | |
| killed. | |
| If you remove tasks from the :term:`graph`, any active instances of those tasks | |
| will be killed and removed from the workflow when you reload or restart. |
Comment on lines
+165
to
+167
| Active instances of tasks removed from the | ||
| graph will be removed (by ``cylc remove``) from the workflow. | ||
| Their active jobs, if they have any, will be killed. |
Member
There was a problem hiding this comment.
Suggested change
| Active instances of tasks removed from the | |
| graph will be removed (by ``cylc remove``) from the workflow. | |
| Their active jobs, if they have any, will be killed. | |
| Active instances of tasks removed from the | |
| graph will be removed from the workflow (just like if you called | |
| ``cylc remove`` on them). | |
| Their active jobs, if they have any, will be killed. |
Member
There was a problem hiding this comment.
Could be phrased as in the change log, now (e.g. "My variant of this tweak:" above).
Member
Author
There was a problem hiding this comment.
(raise a suggestion if you want it changed differently)
Member
There was a problem hiding this comment.
Ok:
Suggested change
| Active instances of tasks removed from the | |
| graph will be removed (by ``cylc remove``) from the workflow. | |
| Their active jobs, if they have any, will be killed. | |
| If you remove tasks from the :term:`graph`, any active instances of those tasks | |
| will be killed and removed from the workflow when you reload or restart. |
Comment on lines
+158
to
+159
| :term:`Parentless` tasks will not be inserted into the workflow automatically | ||
| as there is no upstream task to spawn them, so must be inserted manually. |
Member
There was a problem hiding this comment.
Tempted to avoid the term "insert" so as not to encourage long-standing Cylc 7 users to keep outdated mental model in their heads!
Suggested change
| :term:`Parentless` tasks will not be inserted into the workflow automatically | |
| as there is no upstream task to spawn them, so must be inserted manually. | |
| :term:`Parentless` tasks will not appear in the workflow automatically | |
| as there is no upstream task to spawn them, so must be dealt with manually. |
MetRonnie
reviewed
Oct 2, 2026
| Active instances of tasks removed from the | ||
| graph will be removed (by ``cylc remove``) from the workflow. | ||
| Their active jobs, if they have any, will be killed. | ||
|
|
Member
There was a problem hiding this comment.
Ooh, might be good to note this?
Suggested change
| .. note:: | |
| Cylc cannot track when you rename a task; it will consider the change | |
| as removal of one task and addition of another. | |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
document cylc/cylc-flow#7209
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.