Repository navigation
Conversation
d7299c8 to
06c7192
Compare
43faad6 to
14ee6d2
Compare
14ee6d2 to
c79e5b0
Compare
|
@cylc/core - would be good to get this in, if anyone can spare time for a quick review |
jfrost-mo
left a comment
There was a problem hiding this comment.
Looks like a sensible addition to the documentation. There are a couple minor fixes needed, and I'd also suggesting splitting the examples so they either show valid or invalid use, rather than a mix of both in the same example.
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
bdca4c6 to
b9a293d
Compare
|
All review comments addressed, I think @jfrost-mo (Note, examples of use of Jinja2 strings that embed shell variables might seem a bit obtuse, but I've seen users trying to do this sort of thing without really understanding what gets evaluated when and where). |
jfrost-mo
left a comment
There was a problem hiding this comment.
Yep, that reads much more clearly now, thanks.
Only a small additional change requested to link a couple glossary terms, including a new definition of "run host".
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
|
Comments addressed. |
I frequently encounter users who still don't have a good grasp of where Jinja2 and shell variables and code can be used in a workflow, and when and where they are evaluated.
This expands on the relevant documentation a bit, and gives some explicit examples.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.