fix(cubestore): Respect nulls for unique indexes with skip#10553
Merged
Conversation
rebuild_index() was creating index entries for all rows without checking should_index_row(), causing __null__ entries in the unique ByExternalId index during migration. This made subsequent QUEUE ADD without EXTERNAL_ID fail with a unique constraint violation. Also added should_index_row guard to do_insert's uniqueness check as defense in depth.
github-actions
Bot
added
cube store
waralexrom
approved these changes
Mar 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10553 +/- ##
=======================================
Coverage 57.74% 57.74%
=======================================
Files 223 223
Lines 17523 17523
Branches 3605 3605
=======================================
Hits 10118 10118
Misses 6861 6861
Partials 544 544
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebuild_index() was creating index entries for all rows without checking should_index_row(), causing null entries in the unique ByExternalId index during migration. This made subsequent QUEUE ADD without EXTERNAL_ID fail with a unique constraint violation.
Also added should_index_row guard to do_insert's uniqueness check as defense in depth.