fix: update store file to use current directory instead of parent directory - #21
Open
The0mikkel wants to merge 2 commits into
Open
fix: update store file to use current directory instead of parent directory#21The0mikkel wants to merge 2 commits into
The0mikkel wants to merge 2 commits into
Conversation
…th expected usage in Docker
There was a problem hiding this comment.
Pull request overview
Updates the on-disk store location so the bot reads/writes challenge_issues.json in the container’s working directory (/app), aligning with the provided docker-compose.yml volume mount and fixing the regression described in #20.
Changes:
- Adjust
Store.MAPPING_PATHto use a singleos.path.dirname(__file__), so the JSON store resolves to/app/challenge_issues.jsonin the Docker image layout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikkelHebel
requested changes
Jul 19, 2026
MikkelHebel
left a comment
Member
There was a problem hiding this comment.
This fixes Docker but just moves the bug to local dev. python src/main.py runs from the repo root, so removing the second dirname puts the file in src/ instead of at the root.
os.getcwd() might be more robust here than file, since that's already /app in Docker and the repo root locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update fixes #20 by updating the store file location from the same directory, to the parent directory, which was introduced by mistake in 27085b4.
This does cause a breaking change to the current version, and all users are expected to update their deployment to use the current directory (the current configuration in the
docker-compose.ymlfiles provided).If you have not update the
docker-compose.ymlfiles, you should take a copy of the/challenge_issues.json, and store it in the/app/challenge_issues.jsonbefore stopping the container. If the data stored in/challenge_issues.jsonis not backed up before updating, data loss may occur.