fix(core): refactor the old sanitizer to use discord.py's built-in - #19
Open
MikkelHebel wants to merge 2 commits into
Open
fix(core): refactor the old sanitizer to use discord.py's built-in#19MikkelHebel wants to merge 2 commits into
MikkelHebel wants to merge 2 commits into
Conversation
Member
|
I'm setting this on hold, until #16 have been merged, as this PR needs to be updated aftwards. |
MikkelHebel
force-pushed
the
feature/7/sanitization
branch
from
July 31, 2026 22:16
0dba115 to
56305a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the old markdown/mention sanitizer with discord.py's own built-in.
markdown_cleannow usesdiscord.utils.escape_markdowndiscord_cleannow usesdiscord.utils.escape_markdown+discord.utils.escape_mentions, plus a small added regex to also break channel references (<#id>), since discord.py's mention escaping only covers@everyone/@here/user/role mentions and not channel linksNote: this escapes less aggressively than the old version, it only touches constructs that actually render as Markdown or a mention/reference, instead of blanket-escaping characters like
{,(,.,!that never meant anything in context. Same real coverage (formatting breakout, all four mention/reference types), just no more escaping for the sake of it.This closes #7