Skip to content

fix: agent init container env vars when type is deployment - #316

Open
tambovchanin wants to merge 1 commit into
crowdsecurity:mainfrom
tambovchanin:fix/agent-env-vars
Open

fix: agent init container env vars when type is deployment#316
tambovchanin wants to merge 1 commit into
crowdsecurity:mainfrom
tambovchanin:fix/agent-env-vars

Conversation

@tambovchanin

@tambovchanin tambovchanin commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Fix for issue #309

@github-actions github-actions Bot added the needs/kind Kind label required label Nov 24, 2025
@github-actions

Copy link
Copy Markdown

@tambovchanin: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository.

@github-actions

Copy link
Copy Markdown

@tambovchanin: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository.

@tambovchanin

Copy link
Copy Markdown
Contributor Author

/area agent

@tambovchanin

Copy link
Copy Markdown
Contributor Author

/kind fix

@github-actions github-actions Bot added area/agent kind/fix fixing a bug and removed needs/area needs/kind Kind label required labels Nov 24, 2025
@tambovchanin
tambovchanin marked this pull request as ready for review November 24, 2025 22:02
@tambovchanin

Copy link
Copy Markdown
Contributor Author

@LaurenceJJones could you review please

@LaurenceJJones

Copy link
Copy Markdown
Contributor

I'm not that great with kubernetes so I'll ping

@blotus or @sabban who better suited to get merged

@tambovchanin
tambovchanin force-pushed the fix/agent-env-vars branch 2 times, most recently from c6c9dcb to ab12221 Compare December 4, 2025 08:58
@especially-relative

Copy link
Copy Markdown

Any chance this could get dusted off? The deployment mode of crowsdsec agent is still crashing (works after editing the variables or deleting the init container as a workaround)

@especially-relative

Copy link
Copy Markdown

Is there anything blocking this? The agent deployments still fail the LAPI check out of the box due to the issue in #309

@especially-relative

Copy link
Copy Markdown

🥺 🙏

There is no clean good workaround to this really, the use case is configuring a crowdsec agent to ingest from Loki rather than directly ingest from pods.

I was hopeful that the 0.24.0 chart would have it, but nope 😭 😭 😭

@tambovchanin

Copy link
Copy Markdown
Contributor Author

Hello @LaurenceJJones, @blotus, @sabban. Almost half a year has passed since this fix was submitted. If there are any issues with it, please let me know and I'll be happy to fix them.

@especially-relative

Copy link
Copy Markdown

Is this still blocked? 😭 Is there any missing testing? 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants