Skip to content

haproxy: Check for existance of "content[:stick]" (bsc#1062889)#258

Merged
stefannica merged 1 commit into
crowbar:masterfrom
toabctl:bsc-1062889
Nov 6, 2017
Merged

haproxy: Check for existance of "content[:stick]" (bsc#1062889)#258
stefannica merged 1 commit into
crowbar:masterfrom
toabctl:bsc-1062889

Conversation

@toabctl

@toabctl toabctl commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

After a cowbar-ha update, the 'stick' attribute introduced in
PR #208 is missing from the existing node[:haproxy][sections]
entries, which may result in errors such as:

Chef::Mixin::Template::TemplateError
------------------------------------
undefined method `[]' for nil:NilClass

This PR adds checks for the existence of the 'stick' attribute
before dereferencing it.

aspiers
aspiers previously approved these changes Oct 12, 2017
nicolasbock
nicolasbock previously approved these changes Oct 12, 2017
jsuchome
jsuchome previously approved these changes Nov 1, 2017

@jsuchome jsuchome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, silly me

@stefannica stefannica dismissed stale reviews from jsuchome, nicolasbock, and aspiers via cc02ab5 November 2, 2017 11:15
@stefannica stefannica changed the title haproxy: Check for existance of "content[:stick][:on]" (bsc#1062889) haproxy: Check for existance of "content[:stick]" (bsc#1062889) Nov 2, 2017
After a cowbar-ha update, the 'stick' attribute introduced in
commit #74115353 is missing from the existing node[:haproxy][sections]
entries, which may result in errors such as:

Chef::Mixin::Template::TemplateError
------------------------------------
undefined method `[]' for nil:NilClass

This commit adds checks for the existence of the 'stick' attribute
before dereferencing it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants