Skip to content

[UNTESTED] prevent clusters with an even number of nodes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aspiers wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

[UNTESTED] prevent clusters with an even number of nodes #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crowbar_framework/app/models/pacemaker_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,12 @@ def validate_proposal_after_save proposal
elements = proposal["deployment"]["pacemaker"]["elements"]
members = elements["pacemaker-cluster-member"] || []

if members.length.even? && members.length > 2
validation_error I18n.t(
"barclamp.#{bc_name}.validation.cluster_size_even"
)
end

if elements.key?("hawk-server")
elements["hawk-server"].each do |n|
@logger.debug("checking #{n}")
Expand Down
3 changes: 3 additions & 0 deletions crowbar_framework/config/locales/pacemaker/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,3 +124,6 @@ en:
quorum_policy: 'Invalid no-quorum-policy value: %{no_quorum_policy}.'
platform: 'All nodes in proposal must have the same platform.'
pacemaker_proposal: 'Nodes cannot be part of multiple Pacemaker proposals, but %{other_member} is already part of proposal \"%{p_name}\".'
cluster_size_even:
'Clusters must have an odd number of nodes to ensure quorum during
partitioning. 2-node clusters are allowed as a special exception.'