-
Notifications
You must be signed in to change notification settings - Fork 460
Update Docker images to Ubuntu-24.04 and Cargo dependencies [continuation] #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
d1a8d2c
Updated Docker image to Ubuntu-24.04 and Cargo dependencies
MichaIng 796099c
force remove protected packages
Emilgardis ef8648e
fmt
Emilgardis baf7245
make /{bin,sbin,lib,lib64}/ symbolic links to /usr/{bin,sbin,lib,lib64}/
Emilgardis 73400b2
reorder linking
Emilgardis ab41b86
wip: attempt to fix android, not complete
Emilgardis 5876692
don't remove lists prematurely
Emilgardis bce3075
do not set ulimit explicitly, newer buildkit inherits ulimit values
Emilgardis d3476b7
fix mips and non-trixie sources
Emilgardis c16b63d
try to fix i686
Emilgardis 23d2d2d
only test compiler_builtins
Emilgardis 2c12da0
fetch for target only
Emilgardis aea5e75
fix root
Emilgardis 7eed55e
fix i686?
Emilgardis fec8655
use https
Emilgardis 185b63b
fix redirected deb sources
Emilgardis e3fcdb5
fix: revert/format/align for MSRV 1.85 edition 2024
MichaIng cfde57f
chore: minor CI formatting
MichaIng a19a851
ci: handle uppercase characters in repo owner names
MichaIng 7e04c7f
fix: several fixes for several architectures
MichaIng 5f74f6c
fix: xtask: prevent cargo search from printing ANSI color codes
MichaIng a2921b5
chore: apply our ubuntu.sources for zig image builds as well
MichaIng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took me a while to find the repo setting to grant
GITHUB_TOKENwrite access to PR comments, to leave/ci tryrelated comments. The error message without it gave the impression access tosecretswould be the issue, hence using the identicalgithub.tokenpayload was an attempt to fix this on my fork, before I found the repo setting which actually fixed it.Hence changes to both workflows could be reverted, but
github.tokenis used in some places already, and the modern/clearer way to access the token. Hence I suggest to leave it this way. Functionally, both are 100% identical, including their masking in logs etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, dont know why we went eith the secret here, maybe just habit 😅