Skip to content

Updated _parse_due_date to handle accepting a JSON dictionary object #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jshiflet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated _parse_due_date to handle accepting a JSON dictionary object #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions custom_components/reminders_api/todo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,32 @@ def todo_items(self) -> list[TodoItem] | None:
if (uid := self._reminder_uid(reminder))
]

def _parse_due_date(self, due_date_str: str | None) -> datetime | None:
"""Parse due date string to datetime."""
if not due_date_str:
def _parse_due_date(self, due_date_value) -> datetime | None:
if not due_date_value:
return None

if isinstance(due_date_value, dict):
due_date_value = (
due_date_value.get("iso")
or due_date_value.get("formatted")
)

if not isinstance(due_date_value, str):
_LOGGER.warning(
"Unsupported due date format: %s",
due_date_value,
)
return None

try:
return datetime.fromisoformat(due_date_str.replace("Z", "+00:00"))
except (ValueError, AttributeError):
_LOGGER.warning("Failed to parse due date: %s", due_date_str)
return datetime.fromisoformat(
due_date_value.replace("Z", "+00:00")
)
except ValueError:
_LOGGER.warning(
"Failed to parse due date: %s",
due_date_value,
)
return None

async def async_create_todo_item(self, item: TodoItem) -> None:
Expand Down Expand Up @@ -237,4 +255,4 @@ def _extract_reminder_id(self, uid: str | None) -> str:
# Handle IDs prefixed with the x-apple scheme
if uid.startswith("x-apple-reminder://"):
return uid.replace("x-apple-reminder://", "")
return uid
return uid