-
Notifications
You must be signed in to change notification settings - Fork 86
Updated vulnerable packages #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
857ad18
Updated vulnerable packages and Updated all Dockerfiles to use Node.j…
DeepakNemad aaed3a4
Fix: Resolve Dockerfile vulnerabilities and cleanup
DeepakNemad 284d545
Fix: Resolve the Coderabit changes
DeepakNemad 9a636f7
Fix: Resolve Dockerfile vulnerabilities and cleanup
DeepakNemad 4e06601
Fix: Resolve the sonarqube changes
DeepakNemad 2c92b13
Fix: Resolve the sonarqube changes
DeepakNemad 24ad3df
Fix: Resolve the sonarqube changes
DeepakNemad d23d50f
Fix: Resolve the sonarqube changes
DeepakNemad fe80364
Fixed coderabit suggested changes
DeepakNemad b99fa33
Fixed coderabit suggested changes
DeepakNemad ea4df07
All 19 Dockerfiles have been updated consistently while maintaining t…
DeepakNemad 8092250
fixed agent proviosining issue
DeepakNemad bab86b9
Added stable version of openssl
DeepakNemad b0835f8
Added stable version of openssl
DeepakNemad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,83 +1,48 @@ | ||
| # Stage 1: Build the application | ||
| FROM node:18-alpine as build | ||
| # Install OpenSSL | ||
| RUN apk update && apk upgrade | ||
| RUN apk add --no-cache openssl | ||
| RUN set -eux \ | ||
| && apk --no-cache add \ | ||
| openssh-client \ | ||
| aws-cli \ | ||
| docker \ | ||
| docker-compose \ | ||
| jq \ | ||
| && npm install -g pnpm --ignore-scripts \ | ||
| && export PATH=$PATH:/usr/lib/node_modules/pnpm/bin \ | ||
| FROM node:24-alpine3.21 AS build | ||
| RUN apk update && apk upgrade && apk add --no-cache \ | ||
| openssl \ | ||
| openssh-client \ | ||
| aws-cli \ | ||
| docker \ | ||
| docker-compose \ | ||
| jq \ | ||
| && rm -rf /var/cache/apk/* | ||
|
|
||
| # Set the working directory | ||
| RUN npm install -g pnpm@9.15.3 --ignore-scripts | ||
| WORKDIR /app | ||
|
|
||
| # Copy package.json and package-lock.json | ||
| COPY package.json ./ | ||
| COPY pnpm-workspace.yaml ./ | ||
|
|
||
| COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./ | ||
| ENV PUPPETEER_SKIP_DOWNLOAD=true | ||
|
|
||
| # Install dependencies while ignoring scripts (including Puppeteer's installation) | ||
| RUN pnpm i --ignore-scripts | ||
|
|
||
| # Copy the rest of the application code | ||
| RUN pnpm i --frozen-lockfile --ignore-scripts | ||
| COPY . . | ||
|
|
||
| # Generate Prisma client | ||
| # RUN cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate | ||
| RUN cd libs/prisma-service && npx prisma generate | ||
| RUN ls -R /app/apps/agent-provisioning/AFJ/ | ||
|
|
||
| # Build the user service | ||
| RUN pnpm run build agent-provisioning | ||
|
|
||
| # Stage 2: Create the final image | ||
| FROM node:18-alpine as prod | ||
| # Install OpenSSL | ||
| RUN apk update && apk upgrade | ||
| RUN apk add --no-cache openssl | ||
| RUN set -eux \ | ||
| && apk --no-cache add \ | ||
| openssh-client \ | ||
| aws-cli \ | ||
| docker \ | ||
| docker-compose \ | ||
| jq \ | ||
| && npm install -g pnpm --ignore-scripts \ | ||
| && export PATH=$PATH:/usr/lib/node_modules/pnpm/bin \ | ||
| && rm -rf /var/cache/apk/* | ||
|
|
||
| FROM node:24-alpine3.21 | ||
| RUN apk update && apk upgrade && apk add --no-cache \ | ||
| openssl \ | ||
| openssh-client \ | ||
| aws-cli \ | ||
| docker \ | ||
| docker-compose \ | ||
| jq \ | ||
| && rm -rf /var/cache/apk/* \ | ||
| && addgroup -g 1001 -S nodejs \ | ||
| && adduser -S nextjs -u 1001 | ||
| WORKDIR /app | ||
|
|
||
| RUN mkdir -p ./agent-provisioning/AFJ/endpoints | ||
| RUN mkdir -p ./agent-provisioning/AFJ/agent-config | ||
| RUN mkdir -p ./agent-provisioning/AFJ/port-file | ||
| RUN mkdir -p ./agent-provisioning/AFJ/token | ||
|
|
||
|
|
||
| # Copy the compiled code | ||
| RUN mkdir -p ./agent-provisioning/AFJ/endpoints \ | ||
| && mkdir -p ./agent-provisioning/AFJ/agent-config \ | ||
| && mkdir -p ./agent-provisioning/AFJ/port-file \ | ||
| && mkdir -p ./agent-provisioning/AFJ/token | ||
| COPY --from=build /app/dist/apps/agent-provisioning/ ./dist/apps/agent-provisioning/ | ||
| COPY --from=build /app/node_modules ./node_modules | ||
| COPY --from=build /app/node_modules ./node_modules | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| COPY --from=build /app/apps/agent-provisioning/AFJ/scripts ./agent-provisioning/AFJ/scripts | ||
| COPY --from=build /app/apps/agent-provisioning/AFJ/port-file ./agent-provisioning/AFJ/port-file | ||
|
|
||
| # Set permissions | ||
| RUN chmod +x /app/agent-provisioning/AFJ/scripts/start_agent.sh | ||
| RUN chmod +x /app/agent-provisioning/AFJ/scripts/start_agent_ecs.sh | ||
| RUN chmod +x /app/agent-provisioning/AFJ/scripts/docker_start_agent.sh | ||
| RUN chmod +x /app/agent-provisioning/AFJ/scripts/fargate.sh | ||
| RUN chmod 777 /app/agent-provisioning/AFJ/endpoints | ||
| RUN chmod 777 /app/agent-provisioning/AFJ/agent-config | ||
| RUN chmod 777 /app/agent-provisioning/AFJ/token | ||
|
|
||
| # Copy the libs folder | ||
| COPY libs/ ./libs/ | ||
|
|
||
| # Set the command to run the microservice | ||
| CMD ["sh", "-c", "cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate && cd ../.. && node dist/apps/agent-provisioning/main.js"] | ||
| COPY --from=build /app/libs/ ./libs/ | ||
| RUN chmod +x /app/agent-provisioning/AFJ/scripts/*.sh \ | ||
| && chmod 755 /app/agent-provisioning/AFJ/endpoints \ | ||
| && chmod 755 /app/agent-provisioning/AFJ/agent-config \ | ||
| && chmod 755 /app/agent-provisioning/AFJ/token \ | ||
| && chown -R nextjs:nodejs /app/agent-provisioning | ||
| USER nextjs | ||
| CMD ["node", "dist/apps/agent-provisioning/main.js"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,57 +1,35 @@ | ||
| # Stage 1: Build the application | ||
| FROM node:18-alpine as build | ||
| # Install OpenSSL | ||
| RUN apk add --no-cache openssl | ||
| RUN npm install -g pnpm --ignore-scripts \ | ||
| && apk update \ | ||
| && apk add openssh-client \ | ||
| && apk add aws-cli \ | ||
| && apk add docker \ | ||
| && apk add docker-compose | ||
|
|
||
| RUN npm install -g pnpm | ||
| # Set the working directory | ||
| FROM node:24-alpine3.21 AS build | ||
| RUN apk update && apk upgrade && apk add --no-cache \ | ||
| openssl \ | ||
| openssh-client \ | ||
| aws-cli \ | ||
| docker \ | ||
| docker-compose \ | ||
| && rm -rf /var/cache/apk/* | ||
| RUN npm install -g pnpm@9.15.3 --ignore-scripts | ||
| WORKDIR /app | ||
|
|
||
| # Copy package.json and package-lock.json | ||
| COPY package.json ./ | ||
| COPY pnpm-workspace.yaml ./ | ||
|
|
||
| COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./ | ||
| ENV PUPPETEER_SKIP_DOWNLOAD=true | ||
|
|
||
| # Install dependencies while ignoring scripts (including Puppeteer's installation) | ||
| RUN pnpm i --ignore-scripts | ||
|
|
||
| # Copy the rest of the application code | ||
| RUN pnpm i --frozen-lockfile --ignore-scripts | ||
| COPY . . | ||
| # RUN cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate | ||
| RUN cd libs/prisma-service && npx prisma generate | ||
|
|
||
| # Build the user service | ||
| RUN pnpm run build agent-service | ||
|
|
||
| # Stage 2: Create the final image | ||
| FROM node:18-alpine | ||
| # Install OpenSSL | ||
| RUN apk add --no-cache openssl | ||
| RUN npm install -g pnpm --ignore-scripts \ | ||
| && apk update \ | ||
| && apk add openssh-client \ | ||
| && apk add aws-cli \ | ||
| && apk add docker \ | ||
| && apk add docker-compose | ||
|
|
||
| # RUN npm install -g pnpm | ||
| # Set the working directory | ||
| FROM node:24-alpine3.21 | ||
| RUN apk update && apk upgrade && apk add --no-cache \ | ||
| openssl \ | ||
| openssh-client \ | ||
| aws-cli \ | ||
| docker \ | ||
| docker-compose \ | ||
| && rm -rf /var/cache/apk/* \ | ||
| && addgroup -g 1001 -S nodejs \ | ||
| && adduser -S nextjs -u 1001 | ||
| WORKDIR /app | ||
|
|
||
| # Copy the compiled code from the build stage | ||
| COPY --from=build /app/dist/apps/agent-service/ ./dist/apps/agent-service/ | ||
|
|
||
| # Copy the libs folder from the build stage | ||
| COPY --from=build /app/libs/ ./libs/ | ||
| #COPY --from=build /app/package.json ./ | ||
| COPY --from=build /app/node_modules ./node_modules | ||
|
|
||
| # Set the command to run the microservice | ||
| CMD ["sh", "-c", "cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate && cd ../.. && node dist/apps/agent-service/main.js"] | ||
| COPY --from=build /app/node_modules ./node_modules | ||
| USER nextjs | ||
| CMD ["node", "dist/apps/agent-service/main.js"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,24 @@ | ||
| # Stage 1: Build the application | ||
| FROM node:18-alpine as build | ||
| # Install OpenSSL | ||
| RUN apk add --no-cache openssl | ||
| RUN npm install -g pnpm | ||
| # Set the working directory | ||
| FROM node:24-alpine3.21 AS build | ||
| RUN apk update && apk upgrade && apk add --no-cache openssl && rm -rf /var/cache/apk/* | ||
| RUN npm install -g pnpm@9.15.3 --ignore-scripts | ||
| WORKDIR /app | ||
|
|
||
| # Copy package.json and package-lock.json | ||
| COPY package.json ./ | ||
| COPY pnpm-workspace.yaml ./ | ||
| # COPY package-lock.json ./ | ||
|
|
||
| COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./ | ||
| ENV PUPPETEER_SKIP_DOWNLOAD=true | ||
|
|
||
| # Install dependencies while ignoring scripts (including Puppeteer's installation) | ||
| RUN pnpm i --ignore-scripts | ||
|
|
||
| # Copy the rest of the application code | ||
| RUN pnpm i --frozen-lockfile --ignore-scripts | ||
| COPY . . | ||
| # RUN cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate | ||
| RUN cd libs/prisma-service && npx prisma generate | ||
|
|
||
| # Build the api-gateway service | ||
| RUN pnpm run build api-gateway | ||
|
|
||
| # Stage 2: Create the final image | ||
| FROM node:18-alpine | ||
| # Install OpenSSL | ||
| RUN apk add --no-cache openssl | ||
|
|
||
| # Set the working directory | ||
| FROM node:24-alpine3.21 | ||
| RUN apk update && apk upgrade && apk add --no-cache openssl \ | ||
| && rm -rf /var/cache/apk/* \ | ||
| && addgroup -g 1001 -S nodejs \ | ||
| && adduser -S nextjs -u 1001 | ||
| WORKDIR /app | ||
|
|
||
| # Copy the compiled code from the build stage | ||
| COPY --from=build /app/dist/apps/api-gateway/ ./dist/apps/api-gateway/ | ||
|
|
||
| # Copy the libs folder from the build stage | ||
| COPY --from=build /app/libs/ ./libs/ | ||
| COPY --from=build /app/node_modules ./node_modules | ||
| # COPY --from=build /app/uploadedFiles ./uploadedFiles | ||
|
|
||
| # Set the command to run the microservice | ||
| CMD ["sh", "-c", "cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate && cd ../.. && node dist/apps/api-gateway/main.js"] | ||
| COPY --from=build /app/node_modules ./node_modules | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| USER nextjs | ||
| CMD ["node", "dist/apps/api-gateway/main.js"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1,24 @@ | ||
| # Stage 1: Build the application | ||
| FROM node:18-alpine AS build | ||
| # Install OpenSSL | ||
| RUN apk add --no-cache openssl | ||
| RUN npm install -g pnpm | ||
|
|
||
| # Set the working directory | ||
| FROM node:24-alpine3.21 AS build | ||
| RUN apk update && apk upgrade && apk add --no-cache openssl && rm -rf /var/cache/apk/* | ||
| RUN npm install -g pnpm@9.15.3 --ignore-scripts | ||
| WORKDIR /app | ||
|
|
||
| # Copy package.json and package-lock.json | ||
| COPY package.json ./ | ||
| COPY pnpm-workspace.yaml ./ | ||
|
|
||
| COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./ | ||
| ENV PUPPETEER_SKIP_DOWNLOAD=true | ||
|
|
||
| # Install dependencies while ignoring scripts (including Puppeteer's installation) | ||
| RUN pnpm i --ignore-scripts | ||
|
|
||
| # Copy the rest of the application code | ||
| RUN pnpm i --frozen-lockfile --ignore-scripts | ||
| COPY . . | ||
| # RUN cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate | ||
| RUN cd libs/prisma-service && npx prisma generate | ||
|
|
||
| # Build the user service | ||
| RUN pnpm run build cloud-wallet | ||
|
|
||
| # Stage 2: Create the final image | ||
| FROM node:18-alpine | ||
|
|
||
| RUN apk add --no-cache openssl | ||
|
|
||
| # Set the working directory | ||
| FROM node:24-alpine3.21 | ||
| RUN apk update && apk upgrade && apk add --no-cache openssl \ | ||
| && rm -rf /var/cache/apk/* \ | ||
| && addgroup -g 1001 -S nodejs \ | ||
| && adduser -S nextjs -u 1001 | ||
| WORKDIR /app | ||
| # RUN npm install -g pnpm | ||
|
|
||
| # Copy the compiled code from the build stage | ||
| COPY --from=build /app/dist/apps/cloud-wallet/ ./dist/apps/cloud-wallet/ | ||
|
|
||
| # Copy the libs folder from the build stage | ||
| COPY --from=build /app/libs/ ./libs/ | ||
| #COPY --from=build /app/package.json ./ | ||
| COPY --from=build /app/node_modules ./node_modules | ||
|
|
||
|
|
||
| # Set the command to run the microservice | ||
| CMD ["sh", "-c", "cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate && cd ../.. && node dist/apps/cloud-wallet/main.js"] | ||
| COPY --from=build /app/node_modules ./node_modules | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| USER nextjs | ||
| CMD ["node", "dist/apps/cloud-wallet/main.js"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,47 +1,24 @@ | ||
| # Stage 1: Build the application | ||
| FROM node:18-alpine as build | ||
| # Install OpenSSL | ||
| RUN apk add --no-cache openssl | ||
| RUN npm install -g pnpm | ||
| # Set the working directory | ||
| FROM node:24-alpine3.21 AS build | ||
| RUN apk update && apk upgrade && apk add --no-cache openssl && rm -rf /var/cache/apk/* | ||
| RUN npm install -g pnpm@9.15.3 --ignore-scripts | ||
| WORKDIR /app | ||
|
|
||
| # Copy package.json and package-lock.json | ||
| COPY package.json ./ | ||
| COPY pnpm-workspace.yaml ./ | ||
| #COPY package-lock.json ./ | ||
|
|
||
| COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./ | ||
| ENV PUPPETEER_SKIP_DOWNLOAD=true | ||
|
|
||
| # Install dependencies while ignoring scripts (including Puppeteer's installation) | ||
| RUN pnpm i --ignore-scripts | ||
|
|
||
| # Copy the rest of the application code | ||
| RUN pnpm i --frozen-lockfile --ignore-scripts | ||
| COPY . . | ||
| # RUN cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate | ||
| RUN cd libs/prisma-service && npx prisma generate | ||
|
|
||
| # Build the connection service | ||
| RUN pnpm run build connection | ||
|
|
||
| # Stage 2: Create the final image | ||
| FROM node:18-alpine | ||
| # Install OpenSSL | ||
| RUN apk add --no-cache openssl | ||
| # RUN npm install -g pnpm | ||
| # Set the working directory | ||
| FROM node:24-alpine3.21 | ||
| RUN apk update && apk upgrade && apk add --no-cache openssl \ | ||
| && rm -rf /var/cache/apk/* \ | ||
| && addgroup -g 1001 -S nodejs \ | ||
| && adduser -S nextjs -u 1001 | ||
| WORKDIR /app | ||
|
|
||
| # Copy the compiled code from the build stage | ||
| COPY --from=build /app/dist/apps/connection/ ./dist/apps/connection/ | ||
|
|
||
| # Copy the libs folder from the build stage | ||
| COPY --from=build /app/libs/ ./libs/ | ||
| #COPY --from=build /app/package.json ./ | ||
| COPY --from=build /app/node_modules ./node_modules | ||
|
|
||
| # Install production dependencies for the final image | ||
| #RUN npm i --only=production | ||
|
|
||
| # Set the command to run the microservice | ||
| CMD ["sh", "-c", "cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate && cd ../.. && node dist/apps/connection/main.js"] | ||
| COPY --from=build /app/node_modules ./node_modules | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| USER nextjs | ||
| CMD ["node", "dist/apps/connection/main.js"] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: credebl/platform
Length of output: 655
🏁 Script executed:
rg -n '\b(docker|aws)\b' apps/agent-provisioning/ --type=ts -C2Repository: credebl/platform
Length of output: 42
🏁 Script executed:
rg -n 'docker|docker-compose|aws' apps/agent-provisioning/AFJ/ -C2Repository: credebl/platform
Length of output: 13892
🏁 Script executed:
Repository: credebl/platform
Length of output: 42
🏁 Script executed:
rg -n 'spawn|exec|shell' apps/agent-provisioning/src/ --type=ts -B2 -A2Repository: credebl/platform
Length of output: 2358
🏁 Script executed:
rg -n "import.*child_process" apps/agent-provisioning/src/ --type=tsRepository: credebl/platform
Length of output: 157
🏁 Script executed:
cat apps/agent-provisioning/src/agent-provisioning.service.ts | head -100Repository: credebl/platform
Length of output: 4118
Confirm runtime dependency of
aws-cli,docker, anddocker-composepackages.The agent-provisioning service invokes these tools at runtime via shell scripts (
start_agent_ecs.sh,start_agent.sh) executed during wallet provisioning requests. ThewalletProvisionmethod inagent-provisioning.service.tscallsexec()to spin up agent containers and register ECS task definitions. These packages are justified runtime dependencies, though they significantly increase final image size and CVE surface. Consider evaluating whether to use lightweight alternatives or if image size/security posture is acceptable for this service's operational model.🤖 Prompt for AI Agents