Fixes: Refactor ccREL namespace(ns.html) from XHTML+RDFa (XHTML 4) to HTML+RDFa (HTML 5) and Extend Base Template#498
Open
rahulptl165 wants to merge 4 commits into
Open
Conversation
rahulptl165
requested review from
Shafiya-Heena and
TimidRobot
and removed request for
a team
TimidRobot
requested changes
Jan 8, 2025
Member
TimidRobot
left a comment
TimidRobot
left a comment
There was a problem hiding this comment.
This is a great start!
Please update it to better use the template system.
Comment on lines
445
to
450
| <p class="box"> | ||
| <a href="/licenses/by/4.0/" rel="license"> | ||
| <img alt="Creative Commons License" height="31" src="https://licensebuttons.net/l/by/4.0/88x31.png" width="88"/> | ||
| <img alt="Creative Commons License" height="31" src="https://licensebuttons.net/l/by/4.0/88x31.png" width="88"> | ||
| </a> | ||
| Except where otherwise | ||
| <a class="subfoot" href="/policies#license"> |
Member
There was a problem hiding this comment.
This content can be removed. It duplicates the footer now that the base template is used.
Comment on lines
3
to
17
| <!DOCTYPE html> | ||
| <html lang="en" | ||
| xmlns:cc="http://creativecommons.org/ns#" | ||
| xmlns:dcterms="http://purl.org/dc/terms/" | ||
| xmlns:owl="http://www.w3.org/2002/07/owl#" | ||
| xmlns:rddl="http://www.rddl.org/" | ||
| xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" | ||
| xmlns:rdfs="http://www.w3.org/2000/01/rdf-schema#" | ||
| xmlns:xlink="http://www.w3.org/1999/xlink" | ||
| xmlns="http://www.w3.org/1999/xhtml"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title> | ||
| Describing Copyright in RDF - Creative Commons Rights Expression Language | ||
| </title> |
Member
There was a problem hiding this comment.
This duplicates base.html. The content block ({% block content %}) musn't contain <!DOCTYPE>, <html>, <head>, nor <body>.
The template base.html template needs to be updated to support custom ` attributes.
The title should be in a title block ({% block title %}Describing Copyright in RDF - Creative Commons Rights Expression Language{% endblock %}).
Author
|
Hi @TimidRobot , I've addressed the requested changes. Please let me know if there's anything else to improve! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Description
This PR refactors the
ns.htmltemplate for the (ccREL) namespace page to achieve the following:HTML5+RDFa Migration:
Base Template Integration:
ns.htmlfile now extendsbase.html, ensuring the inclusion of a consistent header and footer across the site.Technical details
<img/>, <br/>to<img>, <br>.<rddl:resource>into<section>.<span>tag is opened and immediately closed with</span>.Screenshots
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin