Add support for converting pyformat SQL to positional markers with bulk_parameters#812
Open
bgunebakan wants to merge 1 commit into
Open
Add support for converting pyformat SQL to positional markers with bulk_parameters#812bgunebakan wants to merge 1 commit into
bgunebakan wants to merge 1 commit into
Conversation
Comment on lines
+146
to
+147
| elif bulk_parameters is not None and _NAMED_PARAM_RE.search(sql): | ||
| sql = _rewrite_pyformat_sql(sql) |
Member
There was a problem hiding this comment.
Wouldn't the bulk_parameters also need some sort of conversion and be in dict format for this to work reliably?
Or does pyformat imply that the bulk parameters order matches the order of named placeholders? If so - is that documented somewhere?
Do other clients allow this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Fixes a silent runtime error when
cursor.execute()is called withbulk_parametersand a SQL statement that uses%(name)s(pyformat) placeholders.When
bulk_parametersis passed alongside pyformat SQL, the driver was sending the raw%(name)smarkers verbatim to CrateDB, which rejected them with:SQLParseException[no viable alternative at input 'VALUES (%']The fix adds an elif branch in
execute()that rewrites the SQL template to $N positional markers before the request is sent.The bug was introduced indirectly by PR #810 which declared
paramstyle = "pyformat"for the driver. Before that change, SQLAlchemy generated?style SQL, so thebulk_parameterspath was never fed pyformat placeholders so the broken code path simply didn't exist.It fixes implementation in sqlalchemy-crate package crate/sqlalchemy-cratedb#266
Checklist