Skip to content

fix: increase wallet capabilities timeout from 5s to 30s#7855

Merged
kernelwhisperer merged 2 commits into
release/2026-07-15from
fix/wallet-capabilities-timeout
Jul 16, 2026
Merged

fix: increase wallet capabilities timeout from 5s to 30s#7855
kernelwhisperer merged 2 commits into
release/2026-07-15from
fix/wallet-capabilities-timeout

Conversation

@kernelwhisperer

@kernelwhisperer kernelwhisperer commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

The timeout was too short for some users, causing them to see this screen:

image

To test

  1. Safe+WC
  2. You can place a TWAP

Summary by CodeRabbit

  • Bug Fixes
    • Increased the wait time for wallet capability and provider information requests, reducing premature timeouts during slower connections.

@kernelwhisperer
kernelwhisperer requested a review from a team July 16, 2026 13:37
@kernelwhisperer kernelwhisperer self-assigned this Jul 16, 2026
@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cowfi Ready Ready Preview Jul 16, 2026 2:07pm
explorer-dev Ready Ready Preview Jul 16, 2026 2:07pm
storybook Ready Ready Preview Jul 16, 2026 2:07pm
swap-dev Ready Ready Preview Jul 16, 2026 2:07pm
widget-configurator Ready Ready Preview Jul 16, 2026 2:07pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
cosmos Ignored Ignored Jul 16, 2026 2:07pm
sdk-tools Ignored Ignored Preview Jul 16, 2026 2:07pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 005ee6bd-72da-4027-934f-b57474359004

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The shared wallet capability request timeout increases from 5 seconds to 30 seconds, affecting timeout-wrapped provider metadata and wallet capability fetches.

Changes

Wallet capability timeout behavior

Layer / File(s) Summary
Increase wallet request timeout
libs/wallet/src/api/state/walletCapabilitiesAtom.ts
REQUEST_TIMEOUT_MS changes from 5 seconds to 30 seconds for timeout-wrapped requests.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: danziger

Poem

I nudge the clock from five to thirty,
So wallet fetches need not scurry.
Provider details cross the stream,
Capabilities arrive serene.
— A patient rabbit 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: increasing the wallet capabilities timeout.
Description check ✅ Passed The description includes a summary, screenshot, and basic test notes, but it is lighter than the template's detailed test checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/wallet-capabilities-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploying explorer-dev with  Cloudflare Pages  Cloudflare Pages

Latest commit: 81e62a3
Status: ✅  Deploy successful!
Preview URL: https://d311c4d2.explorer-dev-dxz.pages.dev
Branch Preview URL: https://fix-wallet-capabilities-time.explorer-dev-dxz.pages.dev

View logs

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploying swap-dev with  Cloudflare Pages  Cloudflare Pages

Latest commit: 81e62a3
Status: ✅  Deploy successful!
Preview URL: https://9d2e1c4a.swap-dev-5u6.pages.dev
Branch Preview URL: https://fix-wallet-capabilities-time.swap-dev-5u6.pages.dev

View logs

@alfetopito

Copy link
Copy Markdown
Collaborator

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Comment thread libs/wallet/src/api/state/walletCapabilitiesAtom.ts
@elena-zh

Copy link
Copy Markdown
Contributor

@elena-zh elena-zh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since the issue I've reported above is addressed in #7858

@kernelwhisperer
kernelwhisperer merged commit 6bc347c into release/2026-07-15 Jul 16, 2026
21 of 22 checks passed
@kernelwhisperer
kernelwhisperer deleted the fix/wallet-capabilities-timeout branch July 16, 2026 15:02
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants