feat: introduce separate branches for Safe vs EOA TWAP (WIP)#7851
Draft
Danziger wants to merge 11 commits into
Draft
feat: introduce separate branches for Safe vs EOA TWAP (WIP)#7851Danziger wants to merge 11 commits into
Danziger wants to merge 11 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying explorer-dev with
|
| Latest commit: |
192834a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://92bb7c5d.explorer-dev-dxz.pages.dev |
| Branch Preview URL: | https://feat-eoa-twap-v1.explorer-dev-dxz.pages.dev |
Deploying swap-dev with
|
| Latest commit: |
89a270a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9f2832b9.swap-dev-5u6.pages.dev |
| Branch Preview URL: | https://feat-eoa-twap-v1.swap-dev-5u6.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<<if there's an issue>>Fixes #issueNumber
High-level description of what your changes are accomplishing
Add screenshots if applicable. Images are nice :)
Some example trades:
WETH => USDC on Sepolia, didn't execute: https://dev.explorer.cow.fi/sepolia/orders/0x00d671efcfdfa2ea9f3d71f73e11cf480431bccbe82241a3ea5e849bf411d95392e37a15db9353d9eee1eefdf4c5398b772d59356a5a2684
WETH => USDC on BNB
Orders from my (executed) order should appear here, as this is the proxy wallet that belongs to the EOA I was using: https://dev.explorer.cow.fi/sepolia/address/0xb069b0c059f8d579d9aad69f7a4c742b732513d5
To Test
aboutBackground
Optional: Give background information for changes you've made, that might be difficult to explain via comments