preview: mirror fork PR #7782#7788
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
Clicking "Reload" on the widget loading-error panel tore the panel down immediately and showed a blank iframe, so there was no indication the retry was running until the widget finished loading (or the 30s timeout re-fired). Keep the panel mounted and put it into a loading state instead: disable the button (the existing :disabled style already sets cursor: progress) and swap the copy to "Loading…". The panel is cleared by onWidgetReady on success — which now also re-reveals the iframe — or replaced by onLoadingError on another failure. onLoadingError also removes any existing panel first so repeated failures don't stack panels.
github-actions
Bot
added
the
DONT_MERGE
Deploying explorer-dev with
|
| Latest commit: |
19f3f37
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34f85df6.explorer-dev-dxz.pages.dev |
| Branch Preview URL: | https://cf-preview-pr-7782.explorer-dev-dxz.pages.dev |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Deploying swap-dev with
|
| Latest commit: |
19f3f37
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2a7c13d8.swap-dev-5u6.pages.dev |
| Branch Preview URL: | https://cf-preview-pr-7782.swap-dev-5u6.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mirrors fork PR #7782 for Cloudflare Pages preview builds.
Source PR: #7782
Source fork branch:
tenderdeve/cowswap:fix/7734-widget-retry-loadingMirrored SHA:
19f3f3739ef0Do not merge this PR. Close the source PR to clean up this mirror.