Skip to content

replace serde_yaml 0.9 to yaml_serde 0.10#5564

Open
kazan417 wants to merge 2 commits into
coreos:mainfrom
kazan417:main
Open

replace serde_yaml 0.9 to yaml_serde 0.10#5564
kazan417 wants to merge 2 commits into
coreos:mainfrom
kazan417:main

Conversation

@kazan417
Copy link
Copy Markdown

Now yaml organization forked serde_yaml and officially supports this new yaml_serde.

https://yaml.org/ have link to
https://yaml.com/ on main page link to
https://yaml.com/projects/yaml-serde/
and then it links to https://github.com/yaml/yaml-serde
which is now part of the yaml project https://github.com/yaml/
So we should use this new crate https://crates.io/crates/yaml_serde

Motivation

Deprecation notice
serde_yaml is deprecated
v0.9.34+deprecated

Solution

Replace with actively supported yaml_serde
by official yaml-project which is a fork of original lib.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces the deprecated serde_yaml crate with its successor, yaml_serde. The changes in Cargo.toml, Cargo.lock, and the source files are appropriate. I've pointed out one minor issue where an error message in rust/src/utils.rs was not updated to reflect the library change, which could be confusing for debugging.

Comment thread rust/src/utils.rs Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant