replace serde_yaml 0.9 to yaml_serde 0.10#5564
Open
kazan417 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request correctly replaces the deprecated serde_yaml crate with its successor, yaml_serde. The changes in Cargo.toml, Cargo.lock, and the source files are appropriate. I've pointed out one minor issue where an error message in rust/src/utils.rs was not updated to reflect the library change, which could be confusing for debugging.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now yaml organization forked serde_yaml and officially supports this new yaml_serde.
https://yaml.org/ have link to
https://yaml.com/ on main page link to
https://yaml.com/projects/yaml-serde/
and then it links to https://github.com/yaml/yaml-serde
which is now part of the yaml project https://github.com/yaml/
So we should use this new crate https://crates.io/crates/yaml_serde
Motivation
Deprecation notice
serde_yaml is deprecated
v0.9.34+deprecated
Solution
Replace with actively supported yaml_serde
by official yaml-project which is a fork of original lib.