Skip to content

container: Fix version for staged container updates#4951

Closed
travier wants to merge 1 commit into
coreos:mainfrom
travier:main-container-staged-updates
Closed

container: Fix version for staged container updates#4951
travier wants to merge 1 commit into
coreos:mainfrom
travier:main-container-staged-updates

Conversation

@travier
Copy link
Copy Markdown
Member

@travier travier commented May 7, 2024 •
edited
Loading

WIP

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@travier
Copy link
Copy Markdown
Member Author

travier commented May 7, 2024

Draft as I still need to fully test this. Let's see what CI says.

@travier travier force-pushed the main-container-staged-updates branch from a9f41ea to d0e07fa Compare May 9, 2024 09:59
@travier
Copy link
Copy Markdown
Member Author

travier commented May 23, 2024 •
edited
Loading 

[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1357]: + sed -e 's/^/# /'
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: # {
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #   "update-sha256": "39be266dc47a8adcd154564891f8e29b235dd667270a2b6eafc391de7d2459da",
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #   "manifest-diff": {
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #     "n-added": 2,
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #     "n-removed": 2,
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #     "removed-size": 1439964672,
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #     "total-size": 1547739648,
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #     "total": 2,
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #     "added-size": 1547739648
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #   },
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #   "checksum": "39be266dc47a8adcd154564891f8e29b235dd667270a2b6eafc391de7d2459da",
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #   "version": "2",
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #   "origin": "ostree-unverified-image:containers-storage:localhost/fcos-derived",
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #   "osname": "fedora-coreos",
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #   "timestamp": 1715251203,
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: #   "ref-has-new-commit": false
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1998]: # }
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1357]: + fatal 'File '\''out.txt'\'' doesn'\''t match fixed string list '\''"version": "3"'\'''
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1357]: + echo error: File ''\''out.txt'\''' 'doesn'\''t' match fixed string list ''\''"version":' '"3"'\'''
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1357]: error: File 'out.txt' doesn't match fixed string list '"version": "3"'
[2024-05-09T10:43:42.478Z] May 09 10:43:32 qemu0 kola-runext-container-update-check[1357]: + exit 1

@travier travier mentioned this pull request Jan 15, 2025
Closed
travier added a commit to travier/rpm-ostree that referenced this pull request Sep 26, 2025
@travier
test/container: Extend staged update version check
40e94a0 
This test makes sure that when we cache a first version update and then
another update comes in, the second update is properly cached.

Split from: coreos#4951
@travier travier mentioned this pull request Sep 26, 2025
Open
@travier
Copy link
Copy Markdown
Member Author

travier commented Sep 26, 2025

Testing it again in #5499

@travier travier closed this Sep 26, 2025
travier added a commit to travier/rpm-ostree that referenced this pull request Sep 27, 2025
@travier
test/container: Extend staged update version check
1bca9ef 
This test makes sure that when we cache a first version update and then
another update comes in, the second update is properly cached.

Split from: coreos#4951
travier added a commit to travier/rpm-ostree that referenced this pull request Sep 27, 2025
@travier
test/container: Extend staged update version check
56c12d4 
This test makes sure that when we cache a first version update and then
another update comes in, the second update is properly cached.

Split from: coreos#4951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@travier