unit: Bump TimeoutStartSec=5m#3905
Merged
Merged
Conversation
Significantly bump this timeout from the default because we do a lot of stuff on daemon startup. Immediate motivation is https://bugzilla.redhat.com/show_bug.cgi?id=2111817 But this is also related to the same problems that motivated coreos#3850 (cc coreos#2932 ) We switched from the default DBus timeout of 25 seconds to the systemd default of 90s; this bumps us all the way up to 5 minutes. I think the right long term fix is the socket activation, but this is an easy backportable fix that will hopefully paper over spurious failures. (That said, anyone who is hitting this regularly probably has a system too slow to really use, but...let's not stand in their way)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Significantly bump this timeout from the default because
we do a lot of stuff on daemon startup.
Immediate motivation is https://bugzilla.redhat.com/show_bug.cgi?id=2111817
But this is also related to the same problems that motivated
#3850
(cc #2932 )
We switched from the default DBus timeout of 25 seconds to the
systemd default of 90s; this bumps us all the way up to 5 minutes.
I think the right long term fix is the socket activation, but this
is an easy backportable fix that will hopefully paper over spurious
failures.
(That said, anyone who is hitting this regularly probably has
a system too slow to really use, but...let's not stand in their
way)