daemon: If we encounter a startup error, set it as our unit status text#2933
Merged
Conversation
This is a much smaller patch related to coreos#2932 which is about ensuring the client gets the actual errors instead of generic DBus activation failure. The obvious step then would be to have the client ask systemd for the status text, but that's slightly messy right now and I think I'd anyways prefer to go the socket route. But I think this is a useful pattern; basically systemd's `StatusText` facility is useful.
lucab
approved these changes
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a much smaller patch related to
#2932
which is about ensuring the client gets the actual errors instead
of generic DBus activation failure.
The obvious step then would be to have the client ask systemd
for the status text, but that's slightly messy right now and
I think I'd anyways prefer to go the socket route.
But I think this is a useful pattern; basically systemd's
StatusTextfacility is useful.