Skip to content

fix: add --ipv6 flag to docker network create for proper X-Forwarded-For with IPv6 clients #9570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobbiejaxn wants to merge 1 commit into
base: next
Choose a base branch
from
+4 −4
Open

fix: add --ipv6 flag to docker network create for proper X-Forwarded-For with IPv6 clients #9570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bootstrap/helpers/proxy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function connectProxyToNetworks(Server $server)
$commands = $networks->map(function ($network) {
$safe = escapeshellarg($network);
return [
"docker network ls --format '{{.Name}}' | grep '^{$network}$' >/dev/null || docker network create --driver overlay --attachable {$safe} >/dev/null",
"docker network ls --format '{{.Name}}' | grep '^{$network}$' >/dev/null || docker network create --ipv6 --driver overlay --attachable {$safe} >/dev/null",
"docker network connect {$safe} coolify-proxy >/dev/null 2>&1 || true",
"echo 'Successfully connected coolify-proxy to {$safe} network.'",
];
Expand All @@ -120,7 +120,7 @@ function connectProxyToNetworks(Server $server)
$commands = $networks->map(function ($network) {
$safe = escapeshellarg($network);
return [
"docker network ls --format '{{.Name}}' | grep '^{$network}$' >/dev/null || docker network create --attachable {$safe} >/dev/null",
"docker network ls --format '{{.Name}}' | grep '^{$network}$' >/dev/null || docker network create --ipv6 --attachable {$safe} >/dev/null",
"docker network connect {$safe} coolify-proxy >/dev/null 2>&1 || true",
"echo 'Successfully connected coolify-proxy to {$safe} network.'",
];
Expand All @@ -146,15 +146,15 @@ function ensureProxyNetworksExist(Server $server)
$safe = escapeshellarg($network);
return [
"echo 'Ensuring network {$safe} exists...'",
"docker network ls --format '{{.Name}}' | grep -q '^{$network}$' || docker network create --driver overlay --attachable {$safe}",
"docker network ls --format '{{.Name}}' | grep -q '^{$network}$' || docker network create --ipv6 --driver overlay --attachable {$safe}",
];
});
} else {
$commands = $networks->map(function ($network) {
$safe = escapeshellarg($network);
return [
"echo 'Ensuring network {$safe} exists...'",
"docker network ls --format '{{.Name}}' | grep -q '^{$network}$' || docker network create --attachable {$safe}",
"docker network ls --format '{{.Name}}' | grep -q '^{$network}$' || docker network create --ipv6 --attachable {$safe}",
];
});
}
Expand Down
Loading